librepcb: 0.1.4 -> 0.1.5 #99659
Closed
librepcb: 0.1.4 -> 0.1.5 #99659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
requested changes
Nov 4, 2020
|
|
||
| src = fetchFromGitHub { | ||
| owner = "LibrePCB"; | ||
| repo = "LibrePCB"; | ||
| fetchSubmodules = true; | ||
| rev = "ae04eef5a71b5ba66ae2cee6b631c1c933ace535"; | ||
| sha256 = "0wk5qny1jb6n4mwyyrs7syir3hmwxlwazcd80bpxharmsj7p0rzc"; | ||
| rev = "a435c5095c6f94df4da130fe832ea97f42d17901"; |
There was a problem hiding this comment.
Suggested change
| rev = "a435c5095c6f94df4da130fe832ea97f42d17901"; | |
| rev = version; |
prusnak
approved these changes
Nov 5, 2020
|
Please squash the second commit into the first one |
9544c60 / NixOS#96672 removed the samba option `syncPasswordsByPam`. Need to remove this option from the pam module, otherwise it will cause build errors
Otherwise, it's possible building a flake may cause the live CD to run out of memory.
This reverts commit fa6064a.
This fixes both `nix-shell` failing to eval with `nixUnstable`, as well as ofborg's failure to eval on aarch64 due to passing an "unexpected arg" (https://github.com/NixOS/ofborg/blob/1112e3a8c8621203fae71283d700e0383b5e1e80/ofborg/src/nix.rs#L334-L340).
|
reopened a fresh one, hope thats ok... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)