Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.skidl: init at unstable-2020-09-15 #99634

Merged
merged 1 commit into from Oct 5, 2020
Merged

python3Packages.skidl: init at unstable-2020-09-15 #99634

merged 1 commit into from Oct 5, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Oct 5, 2020 •
edited

Motivation for this change

Adds skidl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthuszagh
Copy link
Contributor Author

@jonringer done.

jonringer
jonringer approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
python2 failure unrelated

https://github.com/NixOS/nixpkgs/pull/99634
1 package failed to build:
python27Packages.skidl

2 packages built:
python37Packages.skidl python38Packages.skidl

@jonringer jonringer merged commit 98e8064 into NixOS:master Oct 5, 2020
@jonringer jonringer mentioned this pull request Oct 5, 2020
Merged
10 tasks
@matthuszagh matthuszagh deleted the skidl branch October 6, 2020 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthuszagh @jonringer