Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sublime-music: 0.11.7 -> 0.11.10 #99663

Merged
merged 4 commits into from Apr 1, 2021
Merged

sublime-music: 0.11.7 -> 0.11.10 #99663

merged 4 commits into from Apr 1, 2021

Conversation

sumnerevans
Copy link
Member

@sumnerevans sumnerevans commented Oct 5, 2020 •
edited

Motivation for this change

This PR

  • Updates Sublime Music to v0.11.10
  • Adds functionality to install the .desktop and .metainfo.xml files as well as the icon for Sublime Music. I had to change the source to use the .tar.gz from the Releases page instead of the source from PyPi because the tar file has those additional resources.
  • Adds me (@sumnerevans) as a maintainer for the sublime-music package. I'm the creator of Sublime Music, and I recently switched to NixOS, so I figured it would be good to add myself to the maintainers list.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sumnerevans sumnerevans changed the title sublime-music: 0.11.7 -> 0.11.9 sublime-music: 0.11.7 -> 0.11.10 Oct 14, 2020
@sumnerevans
Copy link
Member Author

Just added a commit to bump to the latest release of Sublime Music: https://gitlab.com/sublime-music/sublime-music/-/releases/v0.11.10

@sumnerevans
Copy link
Member Author

@albakham when you have a chance.

@albakham
Copy link
Member

albakham commented Nov 4, 2020

@jtojnar

@jtojnar
Copy link
Contributor

jtojnar commented Nov 24, 2020

Looks like it does not build on x86_64-linux but it does on aarch64-linux according to CI.

@ofborg ofborg bot requested a review from albakham March 15, 2021 20:06
@sumnerevans sumnerevans force-pushed the sublime-music-metadata branch 2 times, most recently from ff61801 to fc6c886 Compare March 15, 2021 21:44
@sumnerevans
Copy link
Member Author

OK, it looks like I've fixed the build, now.

@sumnerevans
sublime-music: 0.11.7 -> 0.11.10
535b5a0 
Added the 'bleach' dependency and converted to using the
tarball provided in the upstream release.
@SuperSandro2000 SuperSandro2000 merged commit 682e8ac into NixOS:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@albakham albakham Awaiting requested review from albakham

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sumnerevans @albakham @jtojnar @SuperSandro2000