Skip to content

Navigation Menu

Explore
For
- Enterprise
- Teams
- Startups
- Education
By Solution
Resources
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

NixOS / nixpkgs Public

Notifications
Fork 12.3k
Star 15.7k

Code
Issues 5k+
Pull requests 5k+
Actions
Projects 35
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Pick a username

Email Address

Password

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl88x2bu: 2020-05-19 -> 2020-08-20 #99655

Merged

jonringer merged 1 commit into NixOS:master from NeQuissimus:rtl88x2bu_2020-08-20

Oct 11, 2020

Merged

rtl88x2bu: 2020-05-19 -> 2020-08-20 #99655

jonringer merged 1 commit into NixOS:master from NeQuissimus:rtl88x2bu_2020-08-20

Oct 11, 2020

Conversation 2 Commits 1 Checks 0 Files changed

Conversation

Copy link

Member

NeQuissimus commented Oct 5, 2020

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.

I do not have this hardware but the build works now :)

Ping @NixOS/nixos-release-managers

Sorry, something went wrong.

All reactions


          rtl88x2bu: 2020-05-19 -> 2020-08-20

761ada9

NeQuissimus added 8.has: package (update) 9.needs: port to stable

A PR needs a backport to the stable release.

6.topic: hardware labels

ofborg bot requested a review from Ralith

October 5, 2020 20:22

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels

risicle mentioned this pull request

ZERO Hydra Failures 20.09 #97479

Closed

jonringer approved these changes

View reviewed changes

Copy link

Contributor

jonringer left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99655 1

2 packages marked as broken and skipped:

linuxPackages_hardkernel_4_14.rtl88x2bu
linuxPackages_hardkernel_latest.rtl88x2bu

17 packages built:

linuxPackages-libre.rtl88x2bu
linuxPackages.rtl88x2bu (linuxPackages_5_4.rtl88x2bu)
linuxPackages_4_14.rtl88x2bu
linuxPackages_4_19.rtl88x2bu
linuxPackages_4_4.rtl88x2bu
linuxPackages_4_9.rtl88x2bu
linuxPackages_5_7.rtl88x2bu
linuxPackages_5_8.rtl88x2bu (linuxPackages_latest.rtl88x2bu)
linuxPackages_hardened.rtl88x2bu
linuxPackages_latest-libre.rtl88x2bu
linuxPackages_latest_hardened.rtl88x2bu
linuxPackages_latest_xen_dom0.rtl88x2bu
linuxPackages_latest_xen_dom0_hardened.rtl88x2bu
linuxPackages_testing_bcachefs.rtl88x2bu
linuxPackages_xen_dom0.rtl88x2bu
linuxPackages_xen_dom0_hardened.rtl88x2bu
linuxPackages_zen.rtl88x2bu

Sorry, something went wrong.

All reactions

jonringer merged commit 184e382 into NixOS:master

jonringer approved these changes

View reviewed changes

Copy link

Contributor

jonringer left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99655 1

2 packages marked as broken and skipped:

linuxPackages_hardkernel_4_14.rtl88x2bu
linuxPackages_hardkernel_latest.rtl88x2bu

17 packages built:

linuxPackages-libre.rtl88x2bu
linuxPackages.rtl88x2bu (linuxPackages_5_4.rtl88x2bu)
linuxPackages_4_14.rtl88x2bu
linuxPackages_4_19.rtl88x2bu
linuxPackages_4_4.rtl88x2bu
linuxPackages_4_9.rtl88x2bu
linuxPackages_5_7.rtl88x2bu
linuxPackages_5_8.rtl88x2bu (linuxPackages_latest.rtl88x2bu)
linuxPackages_hardened.rtl88x2bu
linuxPackages_latest-libre.rtl88x2bu
linuxPackages_latest_hardened.rtl88x2bu
linuxPackages_latest_xen_dom0.rtl88x2bu
linuxPackages_latest_xen_dom0_hardened.rtl88x2bu
linuxPackages_testing_bcachefs.rtl88x2bu
linuxPackages_xen_dom0.rtl88x2bu
linuxPackages_xen_dom0_hardened.rtl88x2bu
linuxPackages_zen.rtl88x2bu

Sorry, something went wrong.

All reactions

NeQuissimus deleted the rtl88x2bu_2020-08-20 branch

October 11, 2020 17:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jonringer jonringer approved these changes

Ralith Awaiting requested review from Ralith

Assignees

No one assigned

Labels

6.topic: hardware 8.has: package (update) 9.needs: port to stable

A PR needs a backport to the stable release.

10.rebuild-darwin: 0 10.rebuild-linux: 11-100

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.