[No Merge] pythonPackages.*: bump minor versions #99636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jonringer
force-pushed
the
example-python-update
branch
from
8c65f78
to
ec45df7
Compare
jonringer
changed the title
jonringer
commented
Oct 5, 2020
jonringer
force-pushed
the
example-python-update
branch
from
ec45df7
to
7dd03fb
Compare
jonringer
commented
Oct 5, 2020
Comment on lines
11
to
20
| buildPythonPackage { | ||
| pname = "azure-mgmt-commerce"; | ||
| version = "1.0.1"; | ||
| version = "1.8.2"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| owner = "Azure"; | ||
| repo = "azure-sdk-for-python"; | ||
| rev = "ee5b47525d6c1eae3b1fd5f65b0421eab62a6e6f"; | ||
| sha256 = "0xzdn7da5c3q5knh033vbsqk36vwbm75cx8vf10x0yj58krb4kn4"; | ||
| rev = "azure-core_${version}"; | ||
| sha256 = "1nx0mwkvwy34dpmkp3gbbjxvz12cnj2xr8lrxg1hq9clqkrl9yl5"; | ||
| }; |
There was a problem hiding this comment.
hmm, large mono repos....
There was a problem hiding this comment.
easiest solution I could think of would be to blacklist the repo. Or instead of making a "one-off" exception, just convert these to using fetchPypi
There was a problem hiding this comment.
there's only this and one other azure-mgmt package which are affected by it
thoughts? @FRidh
There was a problem hiding this comment.
I'm leaning towards just using fetchpypi, as I don't think tests are ran anyway
jonringer
commented
Oct 5, 2020
| @@ -8,13 +8,13 @@ assert !useUnrar -> libarchive != null; | |||
|
|
|||
| buildPythonPackage { | |||
There was a problem hiding this comment.
this is missing a rec, but would otherwise be correct
Suggested change
| buildPythonPackage { | |
| buildPythonPackage rec { |
This was referenced Oct 6, 2020
|
related PRs have been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
DO NOT MERGE
follow up to #99635
example of running:
with github fetcher enabled.
This PR will mostly be used to identify script update errors.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)