Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skanlite: 2.0.1 -> 2.2.0 #98750

Merged
merged 1 commit into from Oct 13, 2020
Merged

skanlite: 2.0.1 -> 2.2.0 #98750

merged 1 commit into from Oct 13, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 25, 2020 •
edited

Motivation for this change

Software update + fixes build
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy changed the title rpm-ostree: 2.0.1 -> 2.2.0 skanlite: 2.0.1 -> 2.2.0 Sep 25, 2020
@risicle
Copy link
Contributor

risicle commented Sep 25, 2020

The commit message still says rpm-ostree

@risicle
Copy link
Contributor

risicle commented Sep 25, 2020

Also.. skanlite's build isn't failing. Did you mean to tag this for ZHF?

@freezeboy
Copy link
Contributor Author

https://hydra.nixos.org/build/127854510

@risicle
Copy link
Contributor

risicle commented Sep 25, 2020

Again, merging to master isn't going to fix a problem in release-20.09. This is a fine PR for a general bump, but backporting it isn't going to help get release-20.09 building again. Figuring out what fixed skanlite in master will, though.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@domenkozar domenkozar merged commit 7197c19 into NixOS:master Oct 13, 2020
@freezeboy freezeboy deleted the fix-skanlite branch October 13, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @risicle @jonringer @domenkozar