hotdoc: init at 0.12.2 #98767
Closed
hotdoc: init at 0.12.2 #98767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Sep 25, 2020
| meta = { | ||
| description = "HotDoc: the tastiest API documentation system"; | ||
| homepage = "https://hotdoc.github.io/"; | ||
| license = with lib.licenses; [ lgpl2Plus ]; |
There was a problem hiding this comment.
Suggested change
| license = with lib.licenses; [ lgpl2Plus ]; | |
| license = with lib.licenses; [ lgpl21Plus ]; |
jtojnar
reviewed
Sep 25, 2020
FRidh
reviewed
Sep 25, 2020
doronbehar
force-pushed
the
pkg/hotdoc
branch
from
e1fc2c9
to
cb025ac
Compare
jtojnar
reviewed
Sep 25, 2020
jtojnar
reviewed
Sep 25, 2020
doronbehar
force-pushed
the
pkg/hotdoc
branch
from
cb025ac
to
e9b7c68
Compare
|
@GrahamcOfBorg eval |
jtojnar
reviewed
Sep 26, 2020
doronbehar
force-pushed
the
pkg/hotdoc
branch
from
e9b7c68
to
4f155fe
Compare
FRidh
requested changes
Sep 27, 2020
doronbehar
force-pushed
the
pkg/hotdoc
branch
from
4f155fe
to
abcbdc1
Compare
|
I addressed the latest reviews, but maybe let's not merge it yet? Until we are sure it builds gst's docs right. TBH I don't know if I'll find the time for this in the upcoming weeks. |
SuperSandro2000
requested changes
Jan 18, 2021
| pep8 | ||
| ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
Comment on lines
+25
to
+27
| }; | ||
|
|
||
| } |
There was a problem hiding this comment.
Suggested change
| }; | |
| } | |
| }; | |
| } |
Comment on lines
+51
to
+53
| prePatch = | ||
| # https://github.com/hotdoc/hotdoc/issues/210 | ||
| '' |
There was a problem hiding this comment.
Suggested change
| prePatch = | |
| # https://github.com/hotdoc/hotdoc/issues/210 | |
| '' | |
| # https://github.com/hotdoc/hotdoc/issues/210 | |
| prePatch = '' |
|
@doronbehar friendly ping |
|
I don't see a need for this package if we don't use it to build gst's docs, especially not maintainig it. The work here can be used by someone else if they find a need for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix #98762 .
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)