Correct erroneous reported max lag with prometheus (#10427)

BuckarooBanzay · web-flow · commit c6e3050357e8 · 2020-09-25T18:52:42.000+02:00
Co-authored-by: BuckarooBanzay &lt;BuckarooBanzay@users.noreply.github.com&gt;
diff --git a/src/server.cpp b/src/server.cpp
@@ -653,7 +653,12 @@ void Server::AsyncRunStep(bool initial_step)
 	}
 	m_clients.step(dtime);
 
-	m_lag_gauge->increment((m_lag_gauge->get() > dtime ? -1 : 1) * dtime/100);
+	// increase/decrease lag gauge gradually
+	if (m_lag_gauge->get() > dtime) {
+		m_lag_gauge->decrement(dtime/100);
+	} else {
+		m_lag_gauge->increment(dtime/100);
+	}
 #if USE_CURL
 	// send masterserver announce
 	{

Original file line number	Diff line number	Diff line change
`@@ -653,7 +653,12 @@ void Server::AsyncRunStep(bool initial_step)`
`653`	`653`	`}`
`654`	`654`	`m_clients.step(dtime);`
`655`	`655`
`656`		`- m_lag_gauge->increment((m_lag_gauge->get() > dtime ? -1 : 1) * dtime/100);`
	`656`	`+ // increase/decrease lag gauge gradually`
	`657`	`+ if (m_lag_gauge->get() > dtime) {`
	`658`	`+ m_lag_gauge->decrement(dtime/100);`
	`659`	`+ } else {`
	`660`	`+ m_lag_gauge->increment(dtime/100);`
	`661`	`+ }`
`657`	`662`	`#if USE_CURL`
`658`	`663`	`// send masterserver announce`
`659`	`664`	`{`