Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql_13: init at 13.0 #98696

Merged
merged 2 commits into from Sep 26, 2020
Merged

postgresql_13: init at 13.0 #98696

merged 2 commits into from Sep 26, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 25, 2020

Motivation for this change

https://www.postgresql.org/about/news/2077/
https://www.postgresql.org/docs/13/release-13.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review OK, I also ran nixos/tests/postgresql.nix and nixos/tests/postgis.nix (modified to use pg13).

However, out of the box psql does not seem to use the proper socket to connect to my already running pg12 instance:

$ /nix/store/pph45kx06zd1hiihdwdx61977a3b6m0r-postgresql-13.0/bin/psql 
psql: error: could not connect to server: could not connect to server: No such file or directory
        Is the server running locally and accepting
        connections on Unix domain socket "/tmp/.s.PGSQL.5432"?

When the socket is correctly specified, everything is fine:

$ /nix/store/pph45kx06zd1hiihdwdx61977a3b6m0r-postgresql-13.0/bin/psql -h /run/postgresql
psql (13.0, server 12.4)
Type "help" for help.

lsix=#

Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Seems good now!

@marsam marsam merged commit 69978a0 into NixOS:master Sep 26, 2020
@marsam marsam deleted the init-postgresql_13 branch September 26, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants