Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timewarrior support included extensions on Nix #98803

Closed
wants to merge 1 commit into from
Closed

Timewarrior support included extensions on Nix #98803

wants to merge 1 commit into from

Conversation

bwolf
Copy link
Contributor

@bwolf bwolf commented Sep 25, 2020

The included extensions in share/doc/timew/ext are currently not
usable on NixOS because of missing dependency Python3 and un-patched
shebangs. This PR hopes to fix that.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bwolf
Timewarrior support included extensions on Nix
9fe20db 
The included extensions in share/doc/timew/ext are currently not
usable on NixOS because of missing dependency Python3 and un-patched
shebangs. This PR hopes to fix that.
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from mrVanDalo September 26, 2020 02:03
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@bwolf bwolf closed this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrVanDalo mrVanDalo mrVanDalo approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bwolf @jonringer @mrVanDalo @SuperSandro2000