zerobin: update to v1.0.5 #98734

ju1m · 2020-09-25T10:42:28Z

Update zerobin and dependencies which require an update for this.

Motivation for this change

Use latest zerobin.

Things done

Update zerobin to latest release: 20160108 => v1.0.5
Use buildPythonApplication instead of buildPythonPackage, and replace references in services.zerobin and documentation.
Update Beaker: 1.10.1 => 1.11.0
Update Paste: 3.4.1 => 3.4.3

ento

(I'm following the PR template's suggestion to review open PRs to pay back/forward the work of reviewing, and this is my first time reviewing a nixpkgs PR. I'll defer to experienced reviewers regarding best practices followed in this repo.)

Reviewed points:

Ensure that the commit text fits the guidelines.
Built the package locally on Debian/x86_64.
Executable runs on Debian/x86_64. (Failed with an error; commented with a diff that made it run)

pkgs/development/python-modules/zerobin/default.nix

pkgs/development/python-modules/beaker/default.nix

pkgs/development/python-modules/zerobin/default.nix

pkgs/development/python-modules/beaker/default.nix

pkgs/development/python-modules/zerobin/default.nix

ju1m · 2020-09-27T09:36:47Z

@ento thanks a lot for you extensive reviewing, I wasn't expecting so much help :) I've tried to incorporate all your suggestions in my last push.

doc/languages-frameworks/python.section.md

nixos/modules/services/networking/zerobin.nix

pkgs/applications/misc/zerobin/default.nix

pkgs/development/python-modules/beaker/default.nix

pkgs/applications/misc/zerobin/default.nix

ento

@ju1m Thanks for the updates!

@jonringer @domenkozar @FRidh Could one of you pick up the rest of the review process? As an apprentice reviewer, here's the farthest I'm equipped to contribute :)

Reviewed points so far:

Ensure that the commit text fits the guidelines.
Built the package locally on Debian/x86_64.
Executable runs on Debian/x86_64.

doc/languages-frameworks/python.section.md

pkgs/applications/networking/zerobin/default.nix

nixos-discourse · 2020-11-25T06:49:04Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/385

ju1m · 2021-01-18T15:43:43Z

Removed the commit updating pythonPackages.paste since it has been done in 77fc15d

doronbehar

Other then that and the merge conflicts, LGTM.

pkgs/top-level/all-packages.nix

doronbehar

Eval fails currently due to these.

pkgs/applications/networking/zerobin/default.nix

pkgs/development/python-modules/zerobin/default.nix

ju1m · 2021-03-04T22:49:46Z

Rebased on master, I had to:

disable pyScss's checkPhase.
patch setup.cfg to relax versions of some dependencies.
replace stdenv.lib by lib.

pkgs/applications/networking/zerobin/default.nix

pkgs/development/python-modules/zerobin/default.nix

doc/languages-frameworks/python.section.md

pkgs/applications/networking/zerobin/default.nix

doronbehar · 2021-03-13T12:47:57Z

Result of nixpkgs-review pr 98734 run on x86_64-linux 1

7 packages built:

python38Packages.beaker
python38Packages.pyramid_beaker
python38Packages.pyscss
python39Packages.beaker
python39Packages.pyramid_beaker
python39Packages.pyscss
zerobin

doronbehar · 2021-03-13T12:49:29Z

This is not OK right?

(ins)[nix-shell:~/.cache/nixpkgs-review/pr-98734]$ ./results/zerobin/bin/zerobin --help
Traceback (most recent call last):
  File "/nix/store/44745hzps8f24gch6jx461kilbwk5jc6-zerobin-1.0.5/bin/.zerobin-wrapped", line 6, in <module>
    from zerobin.cli import main
  File "/nix/store/44745hzps8f24gch6jx461kilbwk5jc6-zerobin-1.0.5/lib/python3.8/site-packages/zerobin/cli.py", line 22, in <module>
    from zerobin.routes import get_app
  File "/nix/store/44745hzps8f24gch6jx461kilbwk5jc6-zerobin-1.0.5/lib/python3.8/site-packages/zerobin/routes.py", line 23, in <module>
    from beaker.middleware import SessionMiddleware
  File "/nix/store/jrcqj6iap1565drvcr0b8b3r2fpczfz5-python3.9-Beaker-1.11.0/lib/python3.9/site-packages/beaker/middleware.py", line 11, in <module>
    from beaker.cache import CacheManager
  File "/nix/store/jrcqj6iap1565drvcr0b8b3r2fpczfz5-python3.9-Beaker-1.11.0/lib/python3.9/site-packages/beaker/cache.py", line 15, in <module>
    from beaker.crypto.util import sha1
  File "/nix/store/jrcqj6iap1565drvcr0b8b3r2fpczfz5-python3.9-Beaker-1.11.0/lib/python3.9/site-packages/beaker/crypto/__init__.py", line 5, in <module>
    from beaker.crypto.util import hmac, sha1, hmac_sha1, md5
  File "/nix/store/jrcqj6iap1565drvcr0b8b3r2fpczfz5-python3.9-Beaker-1.11.0/lib/python3.9/site-packages/beaker/crypto/util.py", line 5, in <module>
    from Crypto.Hash import HMAC as hmac, SHA as hmac_sha1
  File "/nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Hash/HMAC.py", line 38, in <module>
    from Crypto.Hash import MD5
  File "/nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Hash/MD5.py", line 29, in <module>
    _raw_md5_lib = load_pycryptodome_raw_lib("Crypto.Hash._MD5",
  File "/nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/_raw_api.py", line 308, in load_pycryptodome_raw_lib
    raise OSError("Cannot load native module '%s': %s" % (name, ", ".join(attempts)))
OSError: Cannot load native module 'Crypto.Hash._MD5': Trying '_MD5.cpython-38-x86_64-linux-gnu.so': cannot load library '/nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.cpython-38-x86_64-linux-gnu.so': /nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.cpython-38-x86_64-linux-gnu.so: cannot open shared object file: No such file or directory.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.cpython-38-x86_64-linux-gnu.so', Trying '_MD5.abi3.so': cannot load library '/nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.abi3.so': /nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.abi3.so: cannot open shared object file: No such file or directory.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.abi3.so', Trying '_MD5.so': cannot load library '/nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.so': /nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.so: cannot open shared object file: No such file or directory.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/nix/store/igpkzdypdjfzzj8iz960pcgik51b6mms-python3.9-pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.so'

ju1m · 2021-03-13T15:14:25Z

@doronbehar , hmm, I cannot reproduce, it works for me. For you it looks like beaker is importing pycryptodome but it then fails to load pycryptodome-3.9.9/lib/python3.9/site-packages/Crypto/Util/../Hash/_MD5.cpython-38-x86_64-linux-gnu.so.
Maybe pycryptodome should be added to the propagatedBuildInputs of beaker, I don't know.
I cannot reproduce even when using python39Packages :/

ju1m · 2021-03-13T16:04:02Z

@doronbehar, I can reproduce when using nixpkgs-review pr 98734.

doronbehar · 2021-03-13T18:22:59Z

@doronbehar, I can reproduce when using nixpkgs-review pr 98734.

Then it means you need to rebase this on top of latest master and fix it then.

doronbehar · 2021-03-29T17:18:21Z

@ju1m I noticed now that the stacktrace I quoted previously had mixed versions of Python used together, and that's probably why it failed. Now I rebased your branch and checked everything once more and zerobin runs fine. Merging.

ju1m requested review from FRidh and jonringer as code owners September 25, 2020 10:42

ju1m force-pushed the zerobin branch from 686ab44 to 1b25559 Compare September 25, 2020 10:45

ofborg bot added the 6.topic: python label Sep 25, 2020

ofborg bot requested a review from domenkozar September 25, 2020 11:45

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Sep 25, 2020

ento reviewed Sep 26, 2020

View reviewed changes

jonringer reviewed Sep 27, 2020

View reviewed changes

pkgs/development/python-modules/beaker/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/zerobin/default.nix Outdated Show resolved Hide resolved

ju1m force-pushed the zerobin branch from 1b25559 to 08720ef Compare September 27, 2020 09:27

ofborg bot added 6.topic: nixos 8.has: documentation 8.has: module (update) labels Sep 27, 2020

ento reviewed Sep 28, 2020

View reviewed changes

ju1m force-pushed the zerobin branch from 08720ef to 7449252 Compare September 29, 2020 10:27

ofborg bot added 8.has: clean-up 8.has: package (new) labels Sep 29, 2020

ento approved these changes Sep 30, 2020

View reviewed changes

doc/languages-frameworks/python.section.md Outdated Show resolved Hide resolved

pkgs/applications/networking/zerobin/default.nix Show resolved Hide resolved

ju1m force-pushed the zerobin branch from 7449252 to e67d854 Compare October 8, 2020 14:59

ju1m force-pushed the zerobin branch from e67d854 to 60337ca Compare January 18, 2021 14:24

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jan 18, 2021

ju1m requested a review from jonringer January 18, 2021 15:44

doronbehar reviewed Feb 7, 2021

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

ju1m force-pushed the zerobin branch from 60337ca to 25a33cf Compare February 17, 2021 15:31

doronbehar reviewed Feb 19, 2021

View reviewed changes

pkgs/applications/networking/zerobin/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/zerobin/default.nix Outdated Show resolved Hide resolved

ju1m added 2 commits March 4, 2021 23:06

pythonPackages.beaker: 1.10.1 -> 1.11.0

4c42246

pythonPackages.pyscss: disable broken checkPhase

0090fbb

ju1m force-pushed the zerobin branch from 25a33cf to 3b6f2a0 Compare March 4, 2021 22:41

ju1m force-pushed the zerobin branch from 3b6f2a0 to 5587236 Compare March 4, 2021 22:51

ju1m requested a review from doronbehar March 4, 2021 22:55

doronbehar reviewed Mar 6, 2021

View reviewed changes

ju1m force-pushed the zerobin branch from 5587236 to 273a99f Compare March 13, 2021 11:22

ju1m requested a review from doronbehar March 13, 2021 11:45

zerobin: 20160108 -> 1.0.5

a9ce4c4

ju1m force-pushed the zerobin branch from 273a99f to a9ce4c4 Compare March 13, 2021 12:06

doronbehar merged commit c2b66f2 into NixOS:master Mar 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zerobin: update to v1.0.5 #98734

zerobin: update to v1.0.5 #98734

ju1m commented Sep 25, 2020 •

edited

ento left a comment •

edited

ju1m commented Sep 27, 2020 •

edited

ento left a comment

nixos-discourse commented Nov 25, 2020

ju1m commented Jan 18, 2021

doronbehar left a comment

doronbehar left a comment

ju1m commented Mar 4, 2021 •

edited

doronbehar commented Mar 13, 2021

doronbehar commented Mar 13, 2021 •

edited

ju1m commented Mar 13, 2021 •

edited

ju1m commented Mar 13, 2021 •

edited

doronbehar commented Mar 13, 2021

doronbehar commented Mar 29, 2021

zerobin: update to v1.0.5 #98734

zerobin: update to v1.0.5 #98734

Conversation

ju1m commented Sep 25, 2020 • edited

Motivation for this change

Things done

ento left a comment • edited

Choose a reason for hiding this comment

ju1m commented Sep 27, 2020 • edited

ento left a comment

Choose a reason for hiding this comment

nixos-discourse commented Nov 25, 2020

ju1m commented Jan 18, 2021

doronbehar left a comment

Choose a reason for hiding this comment

doronbehar left a comment

Choose a reason for hiding this comment

ju1m commented Mar 4, 2021 • edited

doronbehar commented Mar 13, 2021

doronbehar commented Mar 13, 2021 • edited

ju1m commented Mar 13, 2021 • edited

ju1m commented Mar 13, 2021 • edited

doronbehar commented Mar 13, 2021

doronbehar commented Mar 29, 2021

ju1m commented Sep 25, 2020 •

edited

ento left a comment •

edited

ju1m commented Sep 27, 2020 •

edited

ju1m commented Mar 4, 2021 •

edited

doronbehar commented Mar 13, 2021 •

edited

ju1m commented Mar 13, 2021 •

edited

ju1m commented Mar 13, 2021 •

edited