Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sacc: init at 1.02 #98809

Closed
wants to merge 2,986 commits into from
Closed

sacc: init at 1.02 #98809

wants to merge 2,986 commits into from

Conversation

rapenne-s
Copy link
Member

Motivation for this change

this adds sacc, a simple gopher client
I registered myself as maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92 and others added 30 commits August 7, 2020 20:06
(cherry picked from commit 11fa2d4)
(cherry picked from commit 63576eb)
(cherry picked from commit fca28bc)
(cherry picked from commit 6302eb2)
CI Token Access Control

An authorization issue discovered in the mirroring logic allowed read access to private repositories. This issue is now mitigated in the latest release and is waiting for a CVE ID to be assigned.

https://about.gitlab.com/releases/2020/06/10/critical-security-release-13-0-6-released/
(cherry picked from commit 38a4af7)
(cherry picked from commit 30309e1)
Unfortunately, renaming the patch file causes a rebuild.
(cherry picked from commit 997e631)
The expressions were taken from current master;
the list of commits getting there would be too complex for me.
Re-tested briefly atop 20.03.
The expression was taken from current master;
the list of commits getting there would be too complex for me.
(This doesn't work; fixes come in a child commit.)
This basically syncs the versions with master PR NixOS#94863.
(cherry picked from commit e5e3159)
It appears that the autotools based build isn't supported on Darwin.
Just use the stdenv-builtin cmake build everywhere, as it works just
fine and is simpler.

(cherry picked from commit f509255)
(cherry picked from commit 7602e05)
(cherry picked from commit e513a4e)
@rapenne-s
Copy link
Member Author

It seems I did something wrong to have 1922 files changed.

@lopsided98
Copy link
Contributor

Did you make your commit on the 20.03 branch instead of master?

@saper
Copy link

saper commented Sep 26, 2020

It looks like that sacc 1.01 has been added in the meantime (#93676) by @sternenseemann -- and this is just an update to 1.02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet