Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-viewer: 3.7.5 -> 3.7.9 #98763

Merged
merged 1 commit into from Sep 25, 2020
Merged

youtube-viewer: 3.7.5 -> 3.7.9 #98763

merged 1 commit into from Sep 25, 2020

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Sep 25, 2020 •
edited

Motivation for this change

let youtube-viewer work with youtube api v3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@woffs woffs requested a review from stigtsp as a code owner September 25, 2020 14:47
@stigtsp
Copy link
Member

stigtsp commented Sep 25, 2020

Result of nixpkgs-review pr 98763 1

2 packages built:
  • perl530Packages.WWWYoutubeViewer
  • youtube-viewer (perl532Packages.WWWYoutubeViewer)

stigtsp
stigtsp reviewed Sep 25, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested basic execution of youtube-viewer cli program, but did not view any videos (as it requires a YouTube API key.)

@stigtsp stigtsp merged commit 2035454 into NixOS:master Sep 25, 2020
@woffs woffs mentioned this pull request Sep 25, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@woffs @stigtsp