Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] pciutils: fix build on darwin #98780

Merged
merged 1 commit into from Sep 25, 2020
Merged

[20.09] pciutils: fix build on darwin #98780

merged 1 commit into from Sep 25, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Sep 25, 2020

Add IOKit to macOS prereqs, and patch Makefile to use $CC

Cherry picked commit 00bf15f from #98609

Motivation for this change

ZHF 20.09 #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
pciutils: fix build on darwin
113c22d 
Add IOKit to macOS prereqs, and patch Makefile to use $CC

(cherry picked from commit 00bf15f)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 25, 2020
@risicle
Copy link
Contributor

risicle commented Sep 25, 2020

WFM macos 10.14, linux x86_64

@risicle risicle merged commit 2f5cbdb into NixOS:release-20.09 Sep 25, 2020
@ofborg ofborg bot requested a review from vcunat September 25, 2020 19:48
@r-burns r-burns deleted the backport-pciutils branch September 25, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-burns @risicle