-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodePackages: init hsd, hs-airdrop, hs-client #98725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but the commits should be separated for each new package you introduce to fit CONTRIBUTING.md. Since regenerating nodePackages
would take a lot of time, you can just recreate the commits without changing the contents of this PR itself:
git reset --mixed HEAD~ # undos the commit without changing the working tree
git add pkgs/development/node-packages/default.nix
git add -p pkgs/development/node-packages/node-packages.json # add hsd
git commit -m "nodePackages.hsd: init at 2.2.0"
git add -p pkgs/development/node-packages/node-packages.json # add hs-airdrop
git commit -m "nodePackages.hs-airdrop: init at 0.9.0"
git add -p pkgs/development/node-packages/node-packages.json # add hs-client
git commit -m "nodePackages.hs-client: init at 0.0.9"
git add pkgs/development/node-packages/node-packages.nix
git commit -m "nodePackages: update"
git push -f
Updated commits and rebaed on master. Thanks for the help!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rebased on master, would be great to get this merged... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sometimes helps to leave a comment here when your PR gets buried:
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This is a huge diff! I am a bit afraid of it. |
Unfortunately, this is unavoidable due to the way node packaging is done in nixpkgs. The source of the huge diff is |
Well, if nothing can be done... |
@d-xo What's the purpose of having hs-client in nixpkgs? It's only a JS library. |
Motivation for this change
This adds a few tools related to the
handshake
decentralized naming system.The following tools are added:
hsd
hs-client
hs-airdrop
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)