Reland "FontAccess: Sort fonts in lexicographical order" #25799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 25, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2432815
branch
7 times, most recently
from
f4ae5e2
to
3a08ebc
Compare
This is a reland of 404b7cc426e259c11276d673630c9f094628259f The original CL failed some tests because the code assumes that platform-specific APIs called returned unique data. This was a false assumption. This reland follows another CL: https://crrev.com/c/2438875, which ensures that fonts are not duplicated. Original change's description: > FontAccess: Sort fonts in lexicographical order > > This change ensures fonts are sorted before being cached. This change is > due to a concern about fingerprinting: > w3ctag/design-reviews#399 (comment) > > This change ensures that fonts are sorted in lexicographical order. > > Bug: 1043306 > Change-Id: Ia3acf2a45cb473124df4e489683bdc7bac15dde4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427040 > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810519} Bug: 1043306 Change-Id: Ic3d70744661a838d82349c017a1cb0e8c23a3654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432815 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#812965}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2432815
branch
from
3a08ebc
to
ad59d11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of 404b7cc426e259c11276d673630c9f094628259f
The original CL failed some tests because the code assumes that
platform-specific APIs called returned unique data. This was a false
assumption.
This reland follows another CL: https://crrev.com/c/2438875, which
ensures that fonts are not duplicated.
Original change's description:
Bug: 1043306
Change-Id: Ic3d70744661a838d82349c017a1cb0e8c23a3654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432815
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812965}