Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thc-ipv6: init at 3.6 #98771

Merged
merged 1 commit into from Oct 8, 2020
Merged

thc-ipv6: init at 3.6 #98771

merged 1 commit into from Oct 8, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Sep 25, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

related: #81418

hax404
hax404 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@hax404 hax404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Tested with passive_discovery6

@mweinelt
Copy link
Member

mweinelt commented Oct 8, 2020

All binaries can be executed and the manpage is there. LGTM.

Result of nixpkgs-review pr 98771 1

1 package built:
  • thc-ipv6

@mweinelt mweinelt merged commit 75bf955 into NixOS:master Oct 8, 2020
@ajs124 ajs124 deleted the init/thc-ipv6 branch October 8, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@hax404 hax404 hax404 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @mweinelt @hax404