Add attrs like directory path to registry list output. #4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I've fixed this in a slightly different way (namely making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registry targets can have associated attributes (e.g.
github.com/owner/repo?dir=subdir/in/repo) but the attributes are not displayed on a registry listing. They are currently only visible via the$ nix flake info flake:foocommand, but if there is a problem with the registry entry, an error is displayed without any local information. It is sometimes possible to extract the attribute from the error message, but since the attributes are local information that doesn't depend on the remote object, they should be visible independently of success in accessing the remote object.This can also cause confusion about the registry support for these attributes (see issue #4050).
This patch adds the display of the attributes to the
registry listcommand. At present, the only attribute I'm aware of is the "dir" attribute; in the future it may be appropriate to add filtering if there are attributes that should not be visible.