Skip to content
This repository has been archived by the owner on Dec 27, 2020. It is now read-only.

Commit checker should verify generated files are updated correctly #14

Closed
nielsmh opened this issue Jan 5, 2019 · 1 comment
Closed

Comments

@nielsmh
Copy link

nielsmh commented Jan 5, 2019

There are several generated files checked in to the main repository out of convenience:

  • Makefiles
  • Visual Studio project files
  • Scripting system headers (src/script/(ai,game,template)/)

These files should always be kept updated when a commit modifies the source files they are generated from. The commit checker should verify that re-generating these files do not produce a diff, and fail if there is a difference.

Other generated files checked in are baseset definition files, which are built from a template and translations. Since these are closely tied to translations they should likely be handled by Eints, out of scope of this ticket.

Lastly there is openttd.grf, which requires additional tooling to generate, and might have binary differences depending on the exact versions of the tools used. It should possibly be maintained by a separate job, out of scope of this ticket.

@nielsmh nielsmh changed the title Commit checker should verify that various generated files are updated correctly Commit checker should verify generated files are updated correctly Jan 5, 2019
@LordAro
Copy link
Member

LordAro commented Sep 25, 2020

No longer an issue thanks to OpenTTD/OpenTTD#7270 & OpenTTD/OpenTTD#8192

@LordAro LordAro closed this as completed Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants