Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moodle: 3.9.1 -> 3.9.2 #98788

Merged
merged 2 commits into from Sep 26, 2020
Merged

moodle: 3.9.1 -> 3.9.2 #98788

merged 2 commits into from Sep 26, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 25, 2020 •
edited

Motivation for this change

Package update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from aanderse September 25, 2020 23:53
@aanderse
Copy link
Member

@freezeboy any interest in taking over as maintainer on this package?

@freezeboy
Copy link
Contributor Author

@aanderse No problem for me

@aanderse
Copy link
Member

Thank you very much @freezeboy!

@aanderse aanderse merged commit fc37661 into NixOS:master Sep 26, 2020
@freezeboy freezeboy deleted the update-moodle branch September 26, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @jonringer @aanderse