Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sile: 0.10.10 → 0.10.11 #98787

Merged
merged 1 commit into from Sep 26, 2020
Merged

sile: 0.10.10 → 0.10.11 #98787

merged 1 commit into from Sep 26, 2020

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Sep 25, 2020 •
edited

Motivation for this change

Upstream package update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alerque alerque mentioned this pull request Sep 25, 2020
Closed
18 tasks
@alerque
Copy link
Contributor Author

alerque commented Sep 25, 2020

@doronbehar Ofborg be gibberish to me, hopefully not to thee.

@doronbehar
Copy link
Contributor

This is not your fault. This may not work now:

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from doronbehar September 25, 2020 23:28
@doronbehar doronbehar merged commit 9ed0122 into NixOS:master Sep 26, 2020
@doronbehar doronbehar deleted the sile-0.10.11 branch September 26, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alerque @doronbehar @jonringer