Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Openfortivpn on Darwin Part 2 #98805

Closed
wants to merge 1 commit into from
Closed

Fix Openfortivpn on Darwin Part 2 #98805

wants to merge 1 commit into from

Conversation

bwolf
Copy link
Contributor

@bwolf bwolf commented Sep 25, 2020

Nix/pppd in not allowed on Darwin. In fact I used openfortivpn on my
Darwin machine using the system pppd with success (this is how
openfortivpn is designed how to work). This PR changes the pppd used
on Darwin to be the system pppd and sets up the configure arguments
accordingly.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bwolf
Fix Openfortivpn on Darwin Part 2
24c781b 
Nix/pppd in not allowed on Darwin. In fact I used openfortivpn on my
Darwin machine using the system pppd with success (this is how
openfortivpn is designed how to work). This PR changes the pppd used
on Darwin to be the system pppd and sets up the configure arguments
accordingly.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 25, 2020
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

1 similar comment
@bwolf
Copy link
Contributor Author

bwolf commented Oct 5, 2020

@GrahamcOfBorg eval

@bwolf bwolf closed this Oct 5, 2020
@mattsawyer77
Copy link
Contributor

hello, curious why this was closed? I took @bwolf's version and am using it locally as a custom package, and it appears to work with v1.17.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwolf @jonringer @mattsawyer77