Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasura-graphql-engine: reduce closure size #98807

Merged
merged 1 commit into from Sep 26, 2020
Merged

hasura-graphql-engine: reduce closure size #98807

merged 1 commit into from Sep 26, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 25, 2020 •
edited

Motivation for this change

4.3G to around 80MB closure size, around 98% closure reduction.

Follow up to #95369

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/98807
1 package built:
hasura-graphql-engine

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg eval

@maralorn
Copy link
Member

Great!

Just out of curiosity, can you tell me how you measured this?

maralorn
maralorn approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonringer
Copy link
Contributor Author

Great!

Just out of curiosity, can you tell me how you measured this?

it's listed as one of the check when making a PR:

 Determined the impact on package closure size (by running nix path-info -S before and after)

@jonringer jonringer merged commit 2768436 into NixOS:master Sep 26, 2020
@jonringer jonringer deleted the fix-hasura-closure branch September 26, 2020 03:32
@ingenieroariel
Copy link
Member

ingenieroariel commented Sep 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maralorn maralorn maralorn approved these changes

@ingenieroariel ingenieroariel Awaiting requested review from ingenieroariel

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @maralorn @ingenieroariel