Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm-ostree: 2020.4 -> 2020.5 #98749

Merged
merged 1 commit into from Sep 25, 2020
Merged

rpm-ostree: 2020.4 -> 2020.5 #98749

merged 1 commit into from Sep 25, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 25, 2020 •
edited

Motivation for this change

Software update + fixes build

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from copumpkin September 25, 2020 14:26
jtojnar
jtojnar approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine https://github.com/coreos/rpm-ostree/releases/tag/v2020.5

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Sep 25, 2020
@jtojnar jtojnar merged commit 2c162d4 into NixOS:master Sep 25, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Sep 25, 2020

Thanks.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 25, 2020

Backported as bb76286

@freezeboy freezeboy deleted the fix-rpm-ostree branch September 25, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @jtojnar