Update underline position for -scroll-* tests #25788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test logic passes in Chromium if the underline-position is fixed to from-font. Otherwise Chromium computes the underline position as "auto" and places it too low in relation to the font size. from-font fixes that and makes the test compatible without changing the expectations or logic of the test.
kojiishi
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test logic passes in Chromium if the underline-position is fixed to
from-font. Otherwise Chromium computes the underline position as "auto"
and places it too low in relation to the font size. from-font fixes that
and makes the test compatible without changing the expectations or logic
of the test.