New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polkadot: 0.2.17 -> 0.8.24 #98785
polkadot: 0.2.17 -> 0.8.24 #98785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just build with SKIP_WASM_BUILD=1
and than you don't need nightly.
@GrahamcOfBorg eval |
a57398f
to
baa4c19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've built it locally, works well
baa4c19
to
ab20e84
Compare
ab20e84
to
5bafcbf
Compare
pkgs/applications/blockchains/polkadot/substrate-wasm-builder-runner.patch
Show resolved
Hide resolved
Just adding in that I've synced a full, archival node to be in sync with the network - works fine |
ping |
@GrahamcOfBorg build polkadot |
@andresilva Very nice for getting this going, I am maintaining a similar derivation here which also builds the wasm runtime. I will give this a review Monday. |
@FlorianFranzen the initial version of this PR was also building the runtime, but this required pulling nightly rustc with wasm environment from Mozilla overlay, and I'm not sure if this would be accepted here. In the end anyone that cares about building the runtime should probably be building from source, this is mostly for regular users that just want to sync the chain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if https://github.com/paritytech/substrate ever gets a bump to master, this build will fail (cargoDeps hash will change). Please use an immutable source like a commit or tag
Substrate has had multiple bumps to master since I have opened this PR. The way cargo works is that you define some source for a dependency in the You can have a look at how dependencies are defined in polkadot for example (https://github.com/paritytech/polkadot/blob/master/service/Cargo.toml#L21) where substrate master is also referenced, but the specific commit that they point to is defined in the As far as this PR goes I had to patch one cargo dependency in order to use a more recent version, I did this by pointing a dependency to the git master branch version nixpkgs/pkgs/applications/blockchains/polkadot/substrate-wasm-builder-runner.patch Line 25 in 5bafcbf
Cargo.toml file, but the exact commit that will be checked out is defined here nixpkgs/pkgs/applications/blockchains/polkadot/substrate-wasm-builder-runner.patch Line 11 in 5bafcbf
Cargo.lock file.
|
oh yea, forgot about the lock file nullifying the toml |
ping |
This looks good, thank you. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)