Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/datadog: Don't recommend dd_url for sites, add proper option #98793

Merged
merged 1 commit into from Sep 26, 2020
Merged

nixos/datadog: Don't recommend dd_url for sites, add proper option #98793

merged 1 commit into from Sep 26, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Sep 25, 2020

Turns out, dd_url should only be used in proxy scenarios, not to point
datadog to their EU endpoint - site should be used for that.

The dd_url setting doesn't affect APM, Logs or Live Process intake
which have their own "*_dd_url" settings.

Motivation for this change

Using dd_url from #97775 only worked for the main agent, but not the Process Agent, for example.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
nixos/datadog: Don't recommend dd_url for sites, add proper option
8d52cf5 
Turns out, `dd_url` should only be used in proxy scenarios, not to point
datadog to their EU endpoint - `site` should be used for that.

The `dd_url` setting doesn't affect APM, Logs or Live Process intake
which have their own "*_dd_url" settings.
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@flokli flokli merged commit ecad934 into NixOS:master Sep 26, 2020
@flokli flokli deleted the dd-site branch September 26, 2020 10:27
@flokli
Copy link
Contributor Author

flokli commented Sep 26, 2020

Backported to 20.09 as 17ecf6e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

@arianvp arianvp Awaiting requested review from arianvp

@rvl rvl Awaiting requested review from rvl

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @jonringer @zimbatm