Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renoise: patch audio plugin server #98794

Merged
merged 1 commit into from Jan 18, 2021
Merged

renoise: patch audio plugin server #98794

merged 1 commit into from Jan 18, 2021

Conversation

tomcur
Copy link
Contributor

@tomcur tomcur commented Sep 25, 2020

Motivation for this change

Renoise was unable to find the AudioPluginServer binaries, as it does not look for them in the ./lib subdirectory.

Instead of moving the binaries to ./lib, patch the binaries to look for their dependencies there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 98794 run on x86_64-linux 1

1 package built:
  • renoise

@SuperSandro2000 SuperSandro2000 merged commit f2cbacb into NixOS:master Jan 18, 2021
@tomcur tomcur deleted the fix-renoise-audiopluginserver branch June 18, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomcur @jonringer @SuperSandro2000