[COOP] access reporting: Use infinite timeout for receive. #25787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 25, 2020
Some browsers do not implement COOP reporting. As a result, no reports are received after a 2.5s timeout. Waiting 2.5s many time can reach the global timeout. Sometime, this flakes in between FAIL and TIMEOUT. This patch makes the timeout to be infinite by default to get consistent failure. Bug: 1090273 Change-Id: I081b9c8e944fc50b391753ce0948392b88d3fd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428976 Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810604}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2428976
branch
from
017316a
to
bea9dcf
Compare
|
The following tests are flaky on Chrome dev:
|
|
Due to the changes in this PR, the timeout behaviour seems expected in Firefox nightly (Tests timed out in Firefox). However, many tests become newly flaky in Chrome, with 1/10 run missing/crashing. @Hexcles should I ask the author to take a look? |
|
The crash-flake is at least partially known and is the subject of a complex investigation; see crbug.com/1098413 I'm not clear if this change made it worse or if it already affected this many files - @ArthurSonzogni do you know? The unfortunate thing is that this PR was hoping to fix Firefox instability, but the Firefox stability check was too slow and timed out :(. (Which we don't block on, of course). |
|
Note: this PR is blocking the Exporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some browsers do not implement COOP reporting. As a result, no reports
are received after a 2.5s timeout.
Waiting 2.5s many time can reach the global timeout. Sometime, this
flakes in between FAIL and TIMEOUT.
This patch makes the timeout to be infinite by default to get consistent
failure.
Bug: 1090273
Change-Id: I081b9c8e944fc50b391753ce0948392b88d3fd0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428976
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810604}