Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 70f9c3c6: Variable type #8320

Merged
merged 1 commit into from Sep 25, 2020
Merged

Fix 70f9c3c6: Variable type #8320

merged 1 commit into from Sep 25, 2020

Conversation

stormcone
Copy link
Contributor

The *_filter_criteria variables contain an index, not a cargo.

@LordAro
Copy link
Member

LordAro commented Sep 25, 2020

Seems correct, though there looks like there's some confusion about what type it's supposed to be - SetProducedCargoFilterIndex sets it using an int, and SetCargoFilterArray (re)sets it with a uint. Neither of which are a byte. Ditto for the other variable. Clean that up at the same time?

@stormcone
Fix 70f9c3c: Variable type
6b2f26d 
The *_filter_criteria variables contain an index, not a cargo.
@stormcone
Copy link
Contributor Author

Done.

LordAro
LordAro approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also the usages of said Set* functions, but I don't think we really need to bother with a cast for the parameters there

@LordAro LordAro merged commit 49b75d6 into OpenTTD:master Sep 25, 2020
@stormcone stormcone deleted the patch-1 branch September 25, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stormcone @LordAro