Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsibreak: 0.12.8 -> 0.12.13 #98747

Merged
merged 1 commit into from Sep 25, 2020
Merged

rsibreak: 0.12.8 -> 0.12.13 #98747

merged 1 commit into from Sep 25, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 25, 2020 •
edited

Motivation for this change

Fixes build
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Sep 25, 2020

WFM non-nixos linux x86_64.

@risicle risicle merged commit 2f93218 into NixOS:master Sep 25, 2020
@risicle
Copy link
Contributor

risicle commented Sep 25, 2020

Also, this wasn't failing on master, why the ZHF?

@freezeboy freezeboy mentioned this pull request Sep 25, 2020
Merged
10 tasks
@freezeboy
Copy link
Contributor Author

I saw this package in hydra

https://hydra.nixos.org/build/127852846

@freezeboy freezeboy deleted the fix-rsibreak branch September 25, 2020 20:32
@risicle
Copy link
Contributor

risicle commented Sep 25, 2020

That's it failing to build on release-20.09 though. Committing to master isn't going to fix that.

@freezeboy
Copy link
Contributor Author

Ok that's how I understood the process but I get your point

@risicle
Copy link
Contributor

risicle commented Sep 26, 2020

Yep, the process becomes less and less clear-cut the further the stable and master branches drift apart, but it continues to apply to packages that are broken in both stable and master. If a package is working in master, the task is to figure out what made it work again and whether the fix is non-invasive enough to be brought across to stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @risicle