Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xorg.xorgserver: 1.20.8 -> 1.20.9 #98748

Merged
merged 1 commit into from Oct 23, 2020
Merged

xorg.xorgserver: 1.20.8 -> 1.20.9 #98748

merged 1 commit into from Oct 23, 2020

Conversation

TredwellGit
Copy link
Member

Motivation for this change

https://lists.x.org/archives/xorg-announce/2020-August/003059.html
https://lists.x.org/archives/xorg-announce/2020-August/003058.html

Fixes CVE-2020-14345, CVE-2020-14346, CVE-2020-14361, and CVE-2020-1436.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
    Tested Xwayland
  • Fits CONTRIBUTING.md.

@vcunat vcunat added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 25, 2020
@TredwellGit TredwellGit mentioned this pull request Oct 7, 2020
Closed
4 tasks
@vcunat vcunat mentioned this pull request Oct 9, 2020
Closed
10 tasks
@Emantor Emantor self-requested a review October 11, 2020 07:50
Emantor
Emantor approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tested XWayland locally with sway
  • Successfully ran gnome3 xorg tests

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/256

@andir
Copy link
Member

andir commented Oct 23, 2020

Is there anything holding this back? I'm rebuilding all the affected packages right now to see if there is something of high-profile that is failing.

@andir
Copy link
Member

andir commented Oct 23, 2020

Result of nixpkgs-review pr 98748 1

18 packages marked as broken and skipped:
  • kmymoney
  • libsForQt5.khotkeys
  • libsForQt512.khotkeys
  • libsForQt515.khotkeys
  • rabbitvcs
  • vimiv
  • xfce.xfce4-vala-panel-appmenu-plugin
  • xorg.xf86videoark
  • xorg.xf86videogeode
  • xorg.xf86videoglide
  • xorg.xf86videoi128
  • xorg.xf86videonewport
  • xorg.xf86videos3virge
  • xorg.xf86videosavage
  • xorg.xf86videotga
  • xorg.xf86videov4l
  • xorg.xf86videovoodoo
  • xorg.xf86videowsfb
9 packages failed to build:
  • gnome3.gnome-documents
  • gscan2pdf
  • ib-controller
  • jucipp
  • quodlibet
  • quodlibet-full
  • quodlibet-without-gst-plugins
  • quodlibet-xine
  • quodlibet-xine-full
306 packages built:
  • adapta-gtk-theme
  • akira-unstable
  • almanah
  • amtk
  • autokey
  • autotiling
  • balsa
  • bamf
  • bonzomatic
  • bumblebee
  • caffeine-ng
  • cage
  • calls
  • chrome-gnome-shell
  • cinnamon.cinnamon-common
  • cinnamon.cinnamon-control-center
  • cinnamon.cinnamon-gsettings-overrides
  • cinnamon.cinnamon-screensaver
  • cinnamon.cinnamon-session
  • cinnamon.cinnamon-settings-daemon
  • compcert
  • contrast
  • coqPackages.contribs.zorns-lemma
  • coq_8_10
  • coq_8_11
  • coq_8_12
  • crowbar
  • deja-dup
  • denemo
  • discover (plasma5.discover)
  • dockbarx
  • empathy (gnome3.empathy)
  • ephemeral
  • epiphany (gnome3.epiphany)
  • eql
  • flashfocus
  • flatpak
  • flatpak-builder
  • flent
  • fractal
  • framac
  • frame
  • gImageReader
  • gajim
  • geis
  • genxword
  • girara
  • gitg (gnome3.gitg)
  • gjs (gnome3.gjs)
  • glom
  • gnome-builder
  • gnome-latex
  • gnome-photos (gnome3.gnome-photos)
  • gnome-podcasts
  • gnome-usage (gnome3.gnome-usage)
  • gnome3.accerciser
  • gnome3.anjuta
  • gnome3.bijiben (gnome3.gnome-notes)
  • gnome3.cheese
  • gnome3.devhelp
  • gnome3.gdm
  • gnome3.geary
  • gnome3.gedit
  • gnome3.gnome-applets
  • gnome3.gnome-books
  • gnome3.gnome-calculator
  • gnome3.gnome-calendar
  • gnome3.gnome-characters
  • gnome3.gnome-clocks
  • gnome3.gnome-contacts
  • gnome3.gnome-control-center (gnome3.gnome_control_center)
  • gnome3.gnome-flashback
  • gnome3.gnome-initial-setup
  • gnome3.gnome-maps
  • gnome3.gnome-music
  • gnome3.gnome-panel
  • gnome3.gnome-session (gnome3.gnome_session)
  • gnome3.gnome-shell (gnome3.gnome_shell)
  • gnome3.gnome-software
  • gnome3.gnome-sound-recorder
  • gnome3.gnome-terminal (gnome3.gnome_terminal)
  • gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
  • gnome3.gnome-weather
  • gnome3.gpaste
  • gtksourceview (gnome3.gtksourceview ,gtksourceview3 ,xfce.gtksourceview)
  • gtksourceview4 (gnome3.gtksourceview4)
  • gtksourceviewmm (gnome3.gtksourceviewmm)
  • libdazzle (gnome3.libdazzle)
  • meld (gnome3.meld)
  • gnome3.mutter
  • pantheon.mutter (gnome3.mutter334)
  • nemiver (gnome3.nemiver)
  • gnome3.polari
  • gnome3.pomodoro
  • gnome3.seahorse
  • gnome3.sushi
  • gnome3.totem
  • gnomeExtensions.drop-down-terminal
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • gnomeExtensions.system-monitor
  • gobby5
  • grail
  • gtg
  • gtkd
  • gtkpod
  • gtksourceviewmm4
  • gtranslator
  • gummi
  • gupnp-tools
  • haskellPackages.gi-gtksource
  • haskellPackages.gi-ostree
  • i3
  • i3-gaps
  • i3-layout-manager
  • i3-wk-switch
  • jellyfin-mpv-shim
  • kde-cli-tools (plasma5.kde-cli-tools)
  • kdeplasma-addons (plasma5.kdeplasma-addons)
  • kdev-php
  • kdev-python
  • kdevelop
  • kdevelop-unwrapped
  • kmenuedit (plasma5.kmenuedit)
  • krohnkite
  • kwin (plasma5.kwin)
  • kwin-dynamic-workspaces
  • kwin-tiling
  • libhandy
  • plasma5.khotkeys (libsForQt514.khotkeys)
  • lutris
  • lutris-free
  • lutris-unwrapped
  • lxqt.lxqt-config
  • malcontent-ui
  • mate.mate-applets
  • mate.pluma
  • minder
  • minishift
  • monitor
  • nasc
  • neap
  • newsflash
  • notejot
  • notes-up
  • ocaml-top
  • ostree
  • pa_applet
  • pantheon.appcenter
  • pantheon.elementary-code
  • pantheon.elementary-dock
  • pantheon.elementary-files
  • pantheon.elementary-greeter
  • pantheon.elementary-gsettings-schemas
  • pantheon.elementary-onboarding
  • pantheon.elementary-session-settings
  • pantheon.gala
  • pantheon.notes-up
  • pantheon.sideload
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • pantheon.wingpanel-with-indicators
  • paperwork
  • perl530Packages.OpenGL
  • perl530Packages.PDL
  • perl532Packages.OpenGL
  • perl532Packages.PDL
  • ping
  • plank
  • plasma-desktop (plasma5.plasma-desktop)
  • plasma-workspace (plasma5.plasma-workspace)
  • powerdevil (plasma5.powerdevil)
  • systemsettings (plasma5.systemsettings)
  • plover.dev
  • plover.stable
  • polybarFull
  • powerline (python38Packages.powerline)
  • pspp
  • python27Packages.ewmh
  • python27Packages.pynput
  • python27Packages.pystray
  • python27Packages.xlib
  • python27Packages.xvfbwrapper
  • python37Packages.dogtail
  • python37Packages.ewmh
  • python37Packages.heudiconv
  • python37Packages.i3ipc
  • python37Packages.liblarch
  • python37Packages.nipype
  • python37Packages.powerline
  • python37Packages.py3status
  • python37Packages.pynput
  • python37Packages.pystray
  • python37Packages.pywebview
  • python37Packages.ueberzug
  • python37Packages.xlib
  • python37Packages.xvfbwrapper
  • python38Packages.dogtail
  • python38Packages.ewmh
  • python38Packages.i3ipc
  • python38Packages.liblarch
  • python38Packages.nipype
  • python38Packages.py3status
  • python38Packages.pynput
  • python38Packages.pystray
  • python38Packages.pywebview
  • ueberzug (python38Packages.ueberzug)
  • python38Packages.xlib
  • python38Packages.xvfbwrapper
  • pytrainer
  • quilter
  • raiseorlaunch
  • rednotebook
  • remarkable-mouse
  • rpm-ostree
  • run-scaled
  • safeeyes
  • satallax
  • selinux-sandbox
  • sequeler
  • setzer
  • shortwave
  • slic3r
  • sway-contrib.inactive-windows-transparency
  • sysprof
  • tepl
  • tigervnc
  • tilix
  • touchegg
  • vdrPlugins.vaapidevice
  • virt-manager
  • wacomtablet
  • weston
  • why3
  • x11docker
  • x2goserver
  • xdg-desktop-portal
  • xdg-desktop-portal-gtk
  • xdummy
  • xf86_input_cmt
  • xf86_input_wacom
  • xf86_video_nested
  • xfce.mousepad
  • xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)
  • xfce.xfce4settings (xfce.xfce4-settings)
  • xmonad_log_applet
  • xorg.xf86inputevdev
  • xorg.xf86inputjoystick
  • xorg.xf86inputkeyboard
  • xorg.xf86inputlibinput
  • xorg.xf86inputmouse
  • xorg.xf86inputsynaptics
  • xorg.xf86inputvmmouse
  • xorg.xf86inputvoid
  • xorg.xf86videoamdgpu
  • xorg.xf86videoapm
  • xorg.xf86videoast
  • xorg.xf86videoati
  • xorg.xf86videochips
  • xorg.xf86videocirrus
  • xorg.xf86videodummy
  • xorg.xf86videofbdev
  • xorg.xf86videoglint
  • xorg.xf86videoi740
  • xorg.xf86videointel
  • xorg.xf86videomach64
  • xorg.xf86videomga
  • xorg.xf86videoneomagic
  • xorg.xf86videonouveau
  • xorg.xf86videonv
  • xorg.xf86videoomap
  • xorg.xf86videoopenchrome
  • xorg.xf86videoqxl
  • xorg.xf86videor128
  • xorg.xf86videorendition
  • xorg.xf86videosiliconmotion
  • xorg.xf86videosis
  • xorg.xf86videosisusb
  • xorg.xf86videosuncg6
  • xorg.xf86videosunffb
  • xorg.xf86videosunleo
  • xorg.xf86videotdfx
  • xorg.xf86videotrident
  • xorg.xf86videovboxvideo
  • xorg.xf86videovesa
  • xorg.xf86videovmware
  • xorg.xf86videoxgi
  • xorg.xinit
  • xorg.xorgserver
  • xpad
  • xpra
  • xrdp
  • xvfb_run
  • xwayland
  • zathura

@andir andir merged commit f0af7d2 into NixOS:master Oct 23, 2020
@TredwellGit TredwellGit deleted the xorg.xorgserver branch October 23, 2020 22:49
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TredwellGit @nixos-discourse @andir @Emantor @vcunat