dropbear: enable static build on musl #97376
Closed
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the --enable-static configuration flag that is required in
the case of static builds. Removes explicit mentions of glibc,
and uses generic
stdenv.cc.libc
. The static attribute of thelibc is passed only when it exists.
Motivation for this change
Dropbear currently doesn't build with musl & AArch64. It is
affected by this bug #97351,
but even bypassing that, the resulting build segfaults. I don't
know the exact reason for this, but I think that building with musl,
and passing only a partial set of the flags required for a working
static build, the end result not working was not a huge wonder.
I tested this change to work correctly on AArch64 and x86_64,
both with musl and glibc static build.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)