Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport hovercraft fix #97333

Merged
merged 2 commits into from Sep 7, 2020
Merged

backport hovercraft fix #97333

merged 2 commits into from Sep 7, 2020

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Sep 7, 2020

Motivation for this change

Backport #82641 , unbreaks package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92

@makefu makefu requested a review from Mic92 September 7, 2020 06:59
@makefu makefu changed the base branch from nixos-20.03 to release-20.03 September 7, 2020 07:07
@mweinelt
Copy link
Member

mweinelt commented Sep 7, 2020

Builds and runs up to usage. Thanks!

Result of nixpkgs-review pr 97333 1

1 package built:
  • hovercraft

@mweinelt mweinelt merged commit 4bd1938 into NixOS:release-20.03 Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@Lassulus Lassulus Lassulus approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makefu @mweinelt @Lassulus @KamilaBorowska