nixos/netdata: add config option for disabling analytics #97361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeUnderscore
force-pushed
the
netdata-analytics-optout
branch
from
0a5e53a
to
5c287e6
Compare
DeeUnderscore
changed the title
SirFerdek
approved these changes
Jan 23, 2021
|
merge. anyone? :) |
|
As a note, Netdata is now switching from Google Analytics to a self-hosted solution. This seems to apply to versions 1.29.4 and up. The current version in nixpkgs master is 1.29.3, so it would still send to Google Analytics as far as I can tell, but I'll make note of it in the option description. |
DeeUnderscore
force-pushed
the
netdata-analytics-optout
branch
from
5c287e6
to
4c6d35b
Compare
DeeUnderscore
force-pushed
the
netdata-analytics-optout
branch
from
4c6d35b
to
65b5aaf
Compare
DeeUnderscore
force-pushed
the
netdata-analytics-optout
branch
from
65b5aaf
to
6fd9cce
Compare
sternenseemann
requested changes
Mar 31, 2021
Option disables analytics through the DO_NOT_TRACK environment variable, as detailed in https://learn.netdata.cloud/docs/agent/anonymous-statistics Default is analytics off
DeeUnderscore
force-pushed
the
netdata-analytics-optout
branch
from
6fd9cce
to
28ed298
Compare
|
@ofborg test netdata |
|
Sorry for the thousands of roundtrips! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
services.netdata.enableAnalyticsReporting(default true), an option that sets aDO_NOT_TRACKenvironment variable to inform Netdata that it should not send usage statistics.Motivation for this change
Netdata sends usage statistics to Google Analytics by default. There is an opt out mechanism that requires either placing a file called
.opt-out-from-anonymous-statisticsin Netdata's config directory, or setting theDO_NOT_TRACKenvironment variable; the latter seemed like the easier solution.There is no way to opt out via the config file, so this necessitates a new option. The option defaults to true for consistency with upstream.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)I checked if the systemd unit is configured with the environment variable properly, but did not try to verify whether or not Netdata actually sends or doesn't send analytics according to it.