Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SDC commands used in Litex generated XDC #33

Closed
5 tasks done
tmichalak opened this issue Sep 7, 2020 · 4 comments
Closed
5 tasks done

Add missing SDC commands used in Litex generated XDC #33

tmichalak opened this issue Sep 7, 2020 · 4 comments

Comments

@tmichalak
Copy link
Collaborator

tmichalak commented Sep 7, 2020

The SDC commands used in the auto-generated XDC PR are:

  • create_clock
  • set_false_path
  • set_max_delay
  • set_clock_groups
  • get_clocks

create_clock is already supported in the SDC plugin, however the target net is wrapped in the get_nets command which needs to be handled.

In the first approach all the set_false_path and set_max_delay and set_clock_groups commands shall simply be forwarded to the output SDC and passed 'as is' to VPR.

@mithro
Copy link
Collaborator

mithro commented Sep 9, 2020

@tmichalak - The set_false_path and set_max_delay should be applied to the correct cells and then the data extracted again when writing out the SDC. This is important as the cells might change names, be removed, etc due to optimizations and stuff.

@tmichalak
Copy link
Collaborator Author

@mithro Yes I figured out that simply writing out these commands as the come in in the original SDC will not work.
For example for minilitex_ddr we have:

set_false_path -quiet -to [get_pins -quiet -filter {REF_PIN_NAME == PRE} -of [get_cells -quiet -filter {ars_ff1 == TRUE || ars_ff2 == TRUE}]]

set_max_delay 2 -quiet -from [get_pins -quiet -filter {REF_PIN_NAME == Q} -of [get_cells -quiet -filter {ars_ff1 == TRUE}]] -to [get_pins -quiet -filter {REF_PIN_NAME == D} -of [get_cells -quiet -filter {ars_ff2 == TRUE}]]

so this looks more like applying it to the correct pin.
However, just by looking at the above example it seems that we will need to have the get_pins command support filtering and stuff just like Vivado.
For the first version of the SDC plugin we could:

  1. Ignore/filter out these commands at all
  2. Support only commands with explicit names of the pins like set_max_delay 2 -from pin1 -to pin2

Option 1 is already supported as the read_xdc command overrides the TCL specific unknown procedure handler which results in simply ignoring unknown commands (so in this case all missing SDC commands).

However my guess is that we are leaning towards option 2, right?

@mithro
Copy link
Collaborator

mithro commented Sep 9, 2020

I think we want to support the filtering commands? They should be pretty simple right?

@tmichalak
Copy link
Collaborator Author

Basic versions of all of the necessary commands have been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants