Skip to content

Polygon Triangulation issues #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phkahler opened this issue Sep 7, 2020 · 0 comments · Fixed by #694
Closed

Polygon Triangulation issues #693

phkahler opened this issue Sep 7, 2020 · 0 comments · Fixed by #694
Labels
bug mesh

Comments

@phkahler
Copy link
Member

phkahler commented Sep 7, 2020

System information

SolveSpace version: 3.0-d3da2c8b

Operating system: Fedora 31

Expected behavior

The polygonal sketches should be properly shaded

Actual behavior

All 4 examples fail to in-fill the polygon correctly. Some are the same sketch with points moved to show failure in a different way.

Additional information

I kept these as simple examples of the error in #296 but they are different. The solution to that issue is going to be built on the solution to this one, which I have and will clean up and submit shortly.

polygon_failures.zip
phkahler added a commit to phkahler/solvespace that referenced this issue Sep 8, 2020
@phkahler
Fix solvespace#693 issues.
04fe674 
This set of changes covers all triangulation errors in issue 693. A point coincident with a triangle vertex is OK and needed for bridges, but sometimes the middle point has edges cutting through the triangle that make it a non-ear. We fix that and a couple of off-by-one error (that fixes one of the test cases).
@phkahler phkahler linked a pull request Sep 8, 2020 that will close this issue
Fix issues 296 and 639 #694
Merged
phkahler added a commit that referenced this issue Sep 8, 2020
@phkahler
Fix #693 issues.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7052496 
This set of changes covers all triangulation errors in issue 693. A point coincident with a triangle vertex is OK and needed for bridges, but sometimes the middle point has edges cutting through the triangle that make it a non-ear. We fix that and a couple of off-by-one error (that fixes one of the test cases).
@ruevs ruevs mentioned this issue Oct 15, 2020
Open
devin-ai-integration bot pushed a commit to erkinalp/solvespace that referenced this issue Apr 3, 2025
@phkahler
Fix solvespace#693 issues.
9a74179 
This set of changes covers all triangulation errors in issue 693. A point coincident with a triangle vertex is OK and needed for bridges, but sometimes the middle point has edges cutting through the triangle that make it a non-ear. We fix that and a couple of off-by-one error (that fixes one of the test cases).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mesh
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues 296 and 639 phkahler/solvespace
1 participant
@phkahler