Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnscontrol: 3.2.0 -> 3.3.0, add me as maintainer #97394

Merged
merged 3 commits into from Sep 17, 2020
Merged

dnscontrol: 3.2.0 -> 3.3.0, add me as maintainer #97394

merged 3 commits into from Sep 17, 2020

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Sep 7, 2020 •
edited

Motivation for this change

I need a feature which is only in 3.3.0.

The deps.nix is generated using nix-community/vgo2nix#42 because the master version fails with newer go.mods and the vendor dir got removed between 3.2.0 and 3.3.0. This should help updating other go modules in the future.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Sep 7, 2020
Merged
@ofborg ofborg bot requested a review from mmahut September 7, 2020 21:53
@ehmry
Copy link
Contributor

ehmry commented Sep 16, 2020

Is it possible to use buildGoModule instead of buildGoPackage? https://nixos.org/manual/nixpkgs/stable/#ssec-go-modules 1.5K lines of deps seems excessive to me.

@SuperSandro2000 SuperSandro2000 force-pushed the dnscontrol-3.3.0 branch 2 times, most recently from 356f349 to 85534d6 Compare September 16, 2020 20:34
@SuperSandro2000
Copy link
Member Author

Is it possible to use buildGoModule instead of buildGoPackage?

Thanks for the hint! This makes this update way smaller and better to review.

@ofborg ofborg bot requested a review from kalbasit September 16, 2020 21:02
@ehmry ehmry merged commit 2a14d21 into NixOS:master Sep 17, 2020
@SuperSandro2000 SuperSandro2000 deleted the dnscontrol-3.3.0 branch September 17, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq left review comments

@mmahut mmahut Awaiting requested review from mmahut

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @ehmry @zowoq