Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifiStable: 5.14.22 -> 5.14.23 #97396

Merged
merged 1 commit into from Sep 9, 2020
Merged

unifiStable: 5.14.22 -> 5.14.23 #97396

merged 1 commit into from Sep 9, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Sep 7, 2020

Motivation for this change

Bugfix release: https://community.ui.com/releases/UniFi-Network-Controller-5-14-23/daf90732-30ad-48ee-81e7-1dcb374eba2a

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [x ] Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin and erictapen September 7, 2020 22:19
erictapen
erictapen approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me.

@erictapen erictapen merged commit f6a3e70 into NixOS:master Sep 9, 2020
@bachp bachp deleted the unifi-5.14.23 branch September 10, 2020 18:05
@lheckemann
Copy link
Member

Backported to 20.09: 7362dab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen erictapen approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @lheckemann @erictapen