New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/jetbrains #97359
Update/jetbrains #97359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm intellij-idea works for me and can import, build and run a Scala (sbt) project for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested idea.phpstorm
and idea.idea-community
(using both actively) and everything seems fine.
@kolaente would you mind preparing a backport PR for 20.09? I guess that it's fine to backport patch-level releases to stable :)
@Ma27 Sure, will do. |
Backport is up: #97474 |
The "working" backport: #97477 (It was easier to create a new branch from 20.09 and cherry-pick everything into that again than rebasing the branch I had onto 20.09) |
@kolaente didn't [1] https://git-scm.com/docs/git-rebase#Documentation/git-rebase.txt---ontoltnewbasegt |
@Ma27 I completely forgot that's a thing tbh |
Hey, I didn't find a better place to ask but I tried running
Does anyone know what I need to do to fix this? My knowledge in perl is like non existent, but I would be glad to help :) |
Jetbrains does not use uniform URLs for their products. The problem in this case is MPS. There, the version is not only used in the file to be downloaded, but also partly (major.minor) in the path. Have a look at url = "https://download.jetbrains.com/mps/2020.1/MPS-${version}.tar.gz"; The update script only changes the url = "https://download.jetbrains.com/mps/2020.2/MPS-${version}.tar.gz"; Maybe there is a way to do this in the script as well? Unfortunately, I don't know perl good enough. |
That is good to know. I will create a PR with jetbrains updates and afterwards have a look at the update script :) |
Motivation for this change
Updates various jetbrains IDEs by running the
update.pl
script.I tested the execution of
idea-community
,goland
andphpstorm
. Each of these failed with a segfault but I'm pretty sure this is not a fault of nix or this update since I had this occasionally with the current versions and execution worked in #96449To make sure they work though it would be a good idea if someone reviewing this could also try to build + run them.
I also contacted jetbrains about the segfaults because again, I suspect my particular setup at fault here.
This PR is partially identical with #96449 but contains a few more updates (like phpstorm) which were probably not available at the time of the other PR. Both should be mergable without conflicting each other.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)