Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcpp: add patch for CVE-2019-14274 #97345

Merged
merged 1 commit into from Sep 22, 2020
Merged

mcpp: add patch for CVE-2019-14274 #97345

merged 1 commit into from Sep 22, 2020

Conversation

ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Sep 7, 2020

Fixes #67197

Motivation for this change

Patch CVE-2019-14274. In fact, I'd prefer to see mcpp removed altogether. If anyone feels inclined to do that, please step up. :-) See #68571 for discussion on how to remove mcpp (Xorg dependency).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ckauhaus ckauhaus requested a review from volth September 7, 2020 12:16
@ckauhaus ckauhaus changed the title mccp: add patch for CVE-2019-14274 mcpp: add patch for CVE-2019-14274 Sep 7, 2020
@ckauhaus
Copy link
Contributor Author

@conferno better?

@ckauhaus ckauhaus merged commit 44a70c9 into NixOS:master Sep 22, 2020
@ckauhaus ckauhaus deleted the 67197-mcpp-cve-2019-14274 branch September 22, 2020 14:01
@Izorkin Izorkin mentioned this pull request Sep 23, 2020
Closed
10 tasks
@K900 K900 mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 74: mcpp-2.7.2: 1 advisory
1 participant
@ckauhaus