Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sd-image-raspberrypi4: remove from stable channel #97399

Merged
merged 1 commit into from Sep 7, 2020
Merged

sd-image-raspberrypi4: remove from stable channel #97399

merged 1 commit into from Sep 7, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Sep 7, 2020 •
edited

As described at the moment this was introduced, this is not intended to
be a stable product for NixOS.

ref: #95475 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samueldr
sd-image-raspberrypi4: remove from stable channel
1a67553 
As described at the moment this was introduced, this is not intended to
be a stable product for NixOS.
@worldofpeace worldofpeace added this to the 20.09 milestone Sep 7, 2020
@worldofpeace worldofpeace added this to To Do in 20.09 Blockers via automation Sep 7, 2020
@worldofpeace worldofpeace merged commit 94b8935 into NixOS:release-20.09 Sep 7, 2020
20.09 Blockers automation moved this from To Do to Done Sep 7, 2020
@worldofpeace
Copy link
Contributor

thx @samueldr

@numinit numinit mentioned this pull request Sep 8, 2020
Closed
@worldofpeace worldofpeace added this to In progress in 20.09 Blockers via automation Oct 5, 2020
@worldofpeace worldofpeace removed this from Done in 20.09 Blockers Oct 5, 2020
@worldofpeace worldofpeace moved this from In progress to Done in 20.09 Blockers Oct 5, 2020
@samueldr samueldr deleted the feature/20.09/remove-rpi4-image branch February 26, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
20.09 Blockers
  
Done
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samueldr @worldofpeace