Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo-c: 0.2 -> 20200906 #97403

Closed
wants to merge 1 commit into from
Closed

redo-c: 0.2 -> 20200906 #97403

wants to merge 1 commit into from

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Sep 7, 2020

Includes fixes on job control

Motivation for this change

Update redo-c to latest version which fixes a problem in job control.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

marsam
marsam reviewed Sep 8, 2020
View reviewed changes
pkgs/development/tools/build-managers/redo-c/default.nix Outdated

src = fetchFromGitHub {
owner = "leahneukirchen";
repo = pname;
rev = "v${version}";
sha256 = "11wc2sgw1ssdm83cjdc6ndnp1bv5mzhbw7njw47mk7ri1ic1x51b";
rev = "3a3f0056f357b4fa2b9f725725806d370395ff39";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind using patches instead?

patches = [
  # Fix non implicit job lease detection. Remove with the next release.
  (fetchpatch {
    url = "https://github.com/leahneukirchen/redo-c/commit/3a3f0056f357b4fa2b9f725725806d370395ff39.patch";
    sha256 = "...";
  })
];

@ck3d
Copy link
Contributor Author

ck3d commented Sep 8, 2020

Thanks for reviewing. Sorry, but I am not interested in such a patch, since it complicates the package definition and the overriding.

@ck3d ck3d closed this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ck3d @marsam @ckesg