Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma5: 5.18.5 -> 5.19.5 #97391

Closed
wants to merge 1 commit into from
Closed

plasma5: 5.18.5 -> 5.19.5 #97391

wants to merge 1 commit into from

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Sep 7, 2020

Motivation for this change

Update to a more recent version of the plasma desktop. #94103. This update looks to be more straightforward than the update to 5.18.5 was, though it's impossible to say for sure until it's had more extensive testing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Thra11 Thra11 requested a review from ttuegel as a code owner September 7, 2020 19:43
@ttuegel
Copy link
Member

ttuegel commented Sep 7, 2020

Thanks! This seems fine, but I'll need a chance to test it. We should wait to merge this until after the branches for NixOS 20.09 are made because Plasma 5.19 is not a long-term support series.

@ofborg ofborg bot requested a review from nyanloutre September 7, 2020 21:00
@worldofpeace
Copy link
Contributor

We've branched so no problems there.

nyanloutre
nyanloutre approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@nyanloutre nyanloutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my system, it's working great !

@jakobrs
Copy link
Contributor

jakobrs commented Oct 13, 2020

KDE Plasma 5.20 appears to be released: https://kde.org/announcements/plasma-5.20.0

@jakobrs
Copy link
Contributor

jakobrs commented Oct 13, 2020 •
edited

Tested this on my system and sddm crashes with hardware.nvidia.prime.offload. It works when using nouveau instead. Tried again today and it seems to work now?

@peterhoeg
Copy link
Member

@Thra11, any chance you can change this to the latest 5.20.x release? It supposedly has far superior wayland support.

@Thra11
Copy link
Member Author

Thra11 commented Oct 31, 2020

Yes, although I'm having trouble with the fetch-kde-qt.sh script:

❯ ./maintainers/scripts/fetch-kde-qt.sh pkgs/desktops/plasma-5
--2020-10-31 15:45:14--  https://download.kde.org/stable/plasma/5.20.2/
Resolving download.kde.org (download.kde.org)... 168.119.32.158, 2a01:4f8:242:1ed5::3
Connecting to download.kde.org (download.kde.org)|168.119.32.158|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘stable/plasma/5.20.2/index.html.tmp’

stable/plasma/5.20.2/index.html.tmp                [ <=>                                                                                               ]  38.89K  --.-KB/s    in 0.08s   

2020-10-31 15:45:15 (469 KB/s) - ‘stable/plasma/5.20.2/index.html.tmp’ saved [39825]

Loading robots.txt; please ignore errors.
--2020-10-31 15:45:15--  https://download.kde.org/robots.txt
Reusing existing connection to download.kde.org:443.
HTTP request sent, awaiting response... 404 Not Found
2020-10-31 15:45:15 ERROR 404: Not Found.

Removing stable/plasma/5.20.2/index.html.tmp since it should be rejected.

--2020-10-31 15:45:15--  https://download.kde.org/stable/plasma/5.20.2/?C=N;O=D
Reusing existing connection to download.kde.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘stable/plasma/5.20.2/index.html?C=N;O=D.tmp’

stable/plasma/5.20.2/index.html?C=N;O=D.tmp        [ <=>                                                                                               ]  38.89K  --.-KB/s    in 0.02s   

2020-10-31 15:45:15 (1.81 MB/s) - ‘stable/plasma/5.20.2/index.html?C=N;O=D.tmp’ saved [39825]

Removing stable/plasma/5.20.2/index.html?C=N;O=D.tmp since it should be rejected.

--2020-10-31 15:45:15--  https://download.kde.org/stable/plasma/5.20.2/?C=M;O=A
Reusing existing connection to download.kde.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘stable/plasma/5.20.2/index.html?C=M;O=A.tmp’

stable/plasma/5.20.2/index.html?C=M;O=A.tmp        [ <=>                                                                                               ]  38.89K  --.-KB/s    in 0.02s   

2020-10-31 15:45:15 (2.07 MB/s) - ‘stable/plasma/5.20.2/index.html?C=M;O=A.tmp’ saved [39825]

Removing stable/plasma/5.20.2/index.html?C=M;O=A.tmp since it should be rejected.

--2020-10-31 15:45:15--  https://download.kde.org/stable/plasma/5.20.2/?C=S;O=A
Reusing existing connection to download.kde.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘stable/plasma/5.20.2/index.html?C=S;O=A.tmp’

stable/plasma/5.20.2/index.html?C=S;O=A.tmp        [ <=>                                                                                               ]  38.89K  --.-KB/s    in 0.02s   

2020-10-31 15:45:15 (1.96 MB/s) - ‘stable/plasma/5.20.2/index.html?C=S;O=A.tmp’ saved [39825]

Removing stable/plasma/5.20.2/index.html?C=S;O=A.tmp since it should be rejected.

--2020-10-31 15:45:15--  https://download.kde.org/stable/plasma/5.20.2/?C=D;O=A
Reusing existing connection to download.kde.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘stable/plasma/5.20.2/index.html?C=D;O=A.tmp’

stable/plasma/5.20.2/index.html?C=D;O=A.tmp        [ <=>                                                                                               ]  38.89K  --.-KB/s    in 0.004s  

2020-10-31 15:45:15 (9.98 MB/s) - ‘stable/plasma/5.20.2/index.html?C=D;O=A.tmp’ saved [39825]

Removing stable/plasma/5.20.2/index.html?C=D;O=A.tmp since it should be rejected.

--2020-10-31 15:45:15--  https://download.kde.org/stable/plasma/5.20.2/?C=N;O=A
Reusing existing connection to download.kde.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘stable/plasma/5.20.2/index.html?C=N;O=A.tmp’

stable/plasma/5.20.2/index.html?C=N;O=A.tmp        [ <=>                                                                                               ]  38.89K  --.-KB/s    in 0.06s   

2020-10-31 15:45:15 (693 KB/s) - ‘stable/plasma/5.20.2/index.html?C=N;O=A.tmp’ saved [39825]

Removing stable/plasma/5.20.2/index.html?C=N;O=A.tmp since it should be rejected.

--2020-10-31 15:45:15--  https://download.kde.org/stable/plasma/5.20.2/?C=M;O=D
Reusing existing connection to download.kde.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘stable/plasma/5.20.2/index.html?C=M;O=D.tmp’

stable/plasma/5.20.2/index.html?C=M;O=D.tmp        [ <=>                                                                                               ]  38.89K  --.-KB/s    in 0.02s   

2020-10-31 15:45:15 (1.69 MB/s) - ‘stable/plasma/5.20.2/index.html?C=M;O=D.tmp’ saved [39825]

Removing stable/plasma/5.20.2/index.html?C=M;O=D.tmp since it should be rejected.

--2020-10-31 15:45:15--  https://download.kde.org/stable/plasma/5.20.2/?C=S;O=D
Reusing existing connection to download.kde.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘stable/plasma/5.20.2/index.html?C=S;O=D.tmp’

stable/plasma/5.20.2/index.html?C=S;O=D.tmp        [ <=>                                                                                               ]  38.89K  --.-KB/s    in 0.02s   

2020-10-31 15:45:15 (2.14 MB/s) - ‘stable/plasma/5.20.2/index.html?C=S;O=D.tmp’ saved [39825]

Removing stable/plasma/5.20.2/index.html?C=S;O=D.tmp since it should be rejected.

--2020-10-31 15:45:15--  https://download.kde.org/stable/plasma/5.20.2/?C=D;O=D
Reusing existing connection to download.kde.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘stable/plasma/5.20.2/index.html?C=D;O=D.tmp’

stable/plasma/5.20.2/index.html?C=D;O=D.tmp        [ <=>                                                                                               ]  38.89K  --.-KB/s    in 0.02s   

2020-10-31 15:45:15 (2.34 MB/s) - ‘stable/plasma/5.20.2/index.html?C=D;O=D.tmp’ saved [39825]

Removing stable/plasma/5.20.2/index.html?C=D;O=D.tmp since it should be rejected.

FINISHED --2020-10-31 15:45:15--
Total wall clock time: 1.1s
Downloaded: 9 files, 350K in 0.3s (1.32 MB/s)

This was referenced Nov 17, 2020
Closed
Closed
@hamburger1984
Copy link
Contributor

hamburger1984 commented Nov 18, 2020 •
edited

Suggesting a fix to fetch-kde-qt.sh in Thra11#2 #104684. Any feedback welcome :)

@SuperSandro2000
Copy link
Member

I think this should probably target staging.

@Thra11
Copy link
Member Author

Thra11 commented Nov 24, 2020

Thanks to @hamburger1984's work on the fetch scripts, I have made some progress on updating plasma to 5.20. I've created a new PR, #104810 (targeting staging, thanks @SuperSandro2000!), as it's a little more complicated. Currently stuck on a "cycle detected in references" error.

@Thra11
Copy link
Member Author

Thra11 commented Dec 24, 2020

Superseded by #104810, which has been merged.

@Thra11 Thra11 closed this Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyanloutre nyanloutre nyanloutre approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Thra11 @ttuegel @worldofpeace @jakobrs @peterhoeg @hamburger1984 @SuperSandro2000 @nyanloutre