Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uptade pytest-timeout and x265 derivations #97344

Closed
wants to merge 3 commits into from
Closed

Uptade pytest-timeout and x265 derivations #97344

wants to merge 3 commits into from

Conversation

jpgu-epam
Copy link

@jpgu-epam jpgu-epam commented Sep 7, 2020 •
edited

Motivation for this change

Update the following derivations and remove old patches on those:

  • pytest-timeout: 1.3.3 -> 1.4.2
  • x265: 3.2 -> 3.4
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jpgu-epam jpgu-epam changed the title Nixos 20.03 patches Uptade pytest-timeout and x265 derivations Sep 7, 2020
jonringer
jonringer reviewed Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that your branch name mentions nixos-20.03. Unless it's a security update, this likely won't get backported (due to potential breakages)

pkgs/development/libraries/x265/default.nix Outdated Show resolved Hide resolved
@jpgu-epam
Copy link
Author

I notice that your branch name mentions nixos-20.03. Unless it's a security update, this likely won't get backported (due to potential breakages)

So, should I create a PR to nixpkgs-20.03 as well?

@jpgu-epam jpgu-epam mentioned this pull request Sep 10, 2020
Closed
10 tasks
@FRidh FRidh added this to To do in Python batch upgrade Dec 2, 2020
@SuperSandro2000
Copy link
Member

So, should I create a PR to nixpkgs-20.03 as well?

20.03 is EOL so this is to late.

@SuperSandro2000
Copy link
Member

Please fix the merge conflict.

@tomberek
Copy link
Contributor

both bumps have reached master. src seems to be correct in master as well.

@tomberek tomberek closed this Feb 26, 2021
Python batch upgrade automation moved this from To do to Done Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

@makefu makefu Awaiting requested review from makefu

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Python batch upgrade
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpgu-epam @SuperSandro2000 @tomberek @jonringer