nixos/promscale: init #97372

0x4A6F · 2020-09-07T16:02:19Z

Motivation for this change

Enable service for timescale-prometheus.

Things done

nixos/modules/services/monitoring/timescale-prometheus.nix

aanderse

Thanks for taking care of the password issue!

I have taken the time to actually give this module a review now. I hope at least some of the comments are helpful.

aanderse · 2020-09-11T11:33:29Z

nixos/modules/services/monitoring/timescale-prometheus.nix

+        '';
+      };
+
+      db-connect-retries = mkOption {


Again, purely a style thing, feel free to ignore 100% and then some but... I think most modules typically use a database. prefix for database related options, something like

database = { connect-retries = mkOption { ... }; host = mkOption { ... }; name = mkOption { ... }; };

Consistency is always nice.

If I'm going to stray away from original commandline argument mapping, I'd first should get rid of web-listen-address and use listenAddress and listenPort instead.

nixos/modules/services/monitoring/timescale-prometheus.nix

nixos/tests/timescale-prometheus.nix

0x4A6F

Thanks for your review.

nixos/modules/services/monitoring/timescale-prometheus.nix

0x4A6F · 2020-09-11T19:29:06Z

nixos/modules/services/monitoring/timescale-prometheus.nix

+        '';
+      };
+
+      db-connect-retries = mkOption {


If I'm going to stray away from original commandline argument mapping, I'd first should get rid of web-listen-address and use listenAddress and listenPort instead.

nixos/modules/services/monitoring/timescale-prometheus.nix

aanderse · 2020-09-12T12:08:52Z

Changes are looking good. I left a few minor comments.

I should have asked before but made the assumption it cannot... so I'll ask now: can this program accept a configuration file instead of environment variables?

nixos/tests/timescale-prometheus.nix

aanderse

This looks great. Do we have any subject matter experts in the community that can give this a quick one over? From my perspective we're pretty much ready for a merge 👍

nixos/modules/services/monitoring/timescale-prometheus.nix

0x4A6F · 2020-09-20T21:10:27Z

Thanks, MR is updated addressing your suggestions.

I should also extend services.prometheus with remote_write and remote_read. Probably in another MR #99180, when ready to merge this one.

aanderse

This looks fine to me but you need someone who knows more about prometheus to review this before merge please.

0x4A6F · 2020-10-06T16:22:43Z

I've updated again to reflect the project rename to promscale, depends on #99875.

Thanks for your review. TIme to search for our prometheus experts.
Wondering, it this is better placed in nixos/modules/services/monitoring/prometheus/promscale.nix.

aanderse · 2020-10-06T19:59:36Z

You might consider mentioning this on one of the discourse threads.

nixos-discourse · 2020-10-06T21:45:31Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/324

andir · 2020-10-29T10:04:29Z

nixos/tests/promscale.nix

+            # "-web-cors-origin example.com/public/.*" # corsOrigin:0xc00016dea0
+            ];
+            services.postgresql = {
+              authentication = pkgs.lib.mkOverride 10 ''


You can probably get rid of this by using /run/postgresql/ as "host" in this test. By default postgresql uses the unix user that connects (on NixOS)

Doesn't seem to work without authentication set and db-host = "/run/postgresql/";.
Seems with these settings promscale is started before postgres is up.

0x4A6F · 2020-10-29T23:02:35Z

Currently with promscale 0.1.1 (#102013) the test breaks, because of postgres version mismatch.
Now it needs postgresql 12, tested with following in my local branch:

--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix

-  postgresql = postgresql_11.override { this = postgresql; };
+  postgresql = postgresql_12.override { this = postgresql; };
   postgresqlPackages = recurseIntoAttrs postgresql.pkgs;
   postgresql11Packages = pkgs.postgresqlPackages;
+  postgresql12Packages = pkgs.postgresqlPackages;

andir · 2020-10-30T16:37:40Z

On 15:52 29.10.20, 0x4A6F wrote: @0x4A6F commented on this pull request. Doesn't seem to work without `authentication` set and `db-host = "/run/postgresql/";`. Seems with these settings promscale is started before postgres is up.

I got it working while trying to deploy it to a server. Unfortunately I didn't continue that route as it was insisting on being superuser on my postgres server.

stale · 2021-06-04T08:56:09Z

I marked this as stale due to inactivity. → More info

JamesGuthrie · 2021-11-01T16:57:52Z

@0x4A6F I am taking a look at using this with the latest version of promscale. Are you interested in continuing work on this change? I could support you in getting it merged if so.

0x4A6F · 2021-12-09T20:08:36Z

@JamesGuthrie Yes, but last time I looked at it timescaledb extension was broken for newer PostgreSQL versions.

P.S.: We can move to chat. My contact details are in maintainers/maintainer-list.nix.

benpye · 2022-02-04T07:21:21Z

This looks possible now, as of 2.5.0 timescaledb supports PostgreSQL 14 and promscale 0.7.0 adds support. I've gotten this working in my flake - https://github.com/benpye/nix-config/blob/main/modules/services/promscale.nix . Do you want to try and update this PR or are you happy if I try and submit my version?

Next on my list is to try and get the promscale extension building too.

0x4A6F · 2023-04-11T18:12:06Z

Deprecated upstream.

ofborg bot added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 7, 2020

aanderse reviewed Sep 8, 2020

View reviewed changes

nixos/modules/services/monitoring/timescale-prometheus.nix Outdated Show resolved Hide resolved

0x4A6F force-pushed the master-timescale-prometheus-service branch 3 times, most recently from c53f3cb to 794ffe5 Compare September 10, 2020 16:57

aanderse requested changes Sep 11, 2020

View reviewed changes

0x4A6F commented Sep 11, 2020

View reviewed changes

0x4A6F force-pushed the master-timescale-prometheus-service branch from 2bd44f8 to 1071d7c Compare September 12, 2020 17:54

0x4A6F commented Sep 12, 2020

View reviewed changes

nixos/tests/timescale-prometheus.nix Outdated Show resolved Hide resolved

aanderse requested changes Sep 20, 2020

View reviewed changes

0x4A6F force-pushed the master-timescale-prometheus-service branch from 361e946 to c395a6e Compare September 20, 2020 21:28

0x4A6F mentioned this pull request Sep 30, 2020

timescale-prometheus -> promscale: 0.1.0-beta.4 -> 0.1.0-beta.5 #99179

Merged

10 tasks

aanderse approved these changes Sep 30, 2020

View reviewed changes

0x4A6F force-pushed the master-timescale-prometheus-service branch from c395a6e to e066be5 Compare October 6, 2020 16:19

0x4A6F changed the title ~~nixos/timescale-prometheus: init~~ nixos/promscale: init Oct 6, 2020

0x4A6F requested a review from basvandijk October 6, 2020 16:23

ofborg bot requested a review from kalbasit October 6, 2020 16:30

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 10.rebuild-linux: 1 labels Oct 6, 2020

0x4A6F mentioned this pull request Oct 6, 2020

-flag true prevents other flags from being set timescale/promscale#290

Closed

nixos/promscale: init

ff85bdd

0x4A6F force-pushed the master-timescale-prometheus-service branch from e066be5 to ff85bdd Compare October 8, 2020 18:14

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Oct 8, 2020

andir reviewed Oct 29, 2020

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 1, 2021

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2022

0x4A6F closed this Apr 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nixos/promscale: init #97372

nixos/promscale: init #97372

0x4A6F commented Sep 7, 2020

aanderse left a comment

aanderse Sep 11, 2020

0x4A6F Sep 11, 2020

0x4A6F left a comment

0x4A6F Sep 11, 2020

aanderse commented Sep 12, 2020

aanderse left a comment

0x4A6F commented Sep 20, 2020 •

edited

aanderse left a comment

0x4A6F commented Oct 6, 2020 •

edited

aanderse commented Oct 6, 2020

nixos-discourse commented Oct 6, 2020

andir Oct 29, 2020

0x4A6F Oct 29, 2020

0x4A6F commented Oct 29, 2020

andir commented Oct 30, 2020 via email

stale bot commented Jun 4, 2021

JamesGuthrie commented Nov 1, 2021

0x4A6F commented Dec 9, 2021

benpye commented Feb 4, 2022 •

edited

0x4A6F commented Apr 11, 2023

nixos/promscale: init #97372

nixos/promscale: init #97372

Conversation

0x4A6F commented Sep 7, 2020

Motivation for this change

Things done

aanderse left a comment

Choose a reason for hiding this comment

aanderse Sep 11, 2020

Choose a reason for hiding this comment

0x4A6F Sep 11, 2020

Choose a reason for hiding this comment

0x4A6F left a comment

Choose a reason for hiding this comment

0x4A6F Sep 11, 2020

Choose a reason for hiding this comment

aanderse commented Sep 12, 2020

aanderse left a comment

Choose a reason for hiding this comment

0x4A6F commented Sep 20, 2020 • edited

aanderse left a comment

Choose a reason for hiding this comment

0x4A6F commented Oct 6, 2020 • edited

aanderse commented Oct 6, 2020

nixos-discourse commented Oct 6, 2020

andir Oct 29, 2020

Choose a reason for hiding this comment

0x4A6F Oct 29, 2020

Choose a reason for hiding this comment

0x4A6F commented Oct 29, 2020

andir commented Oct 30, 2020 via email

stale bot commented Jun 4, 2021

JamesGuthrie commented Nov 1, 2021

0x4A6F commented Dec 9, 2021

benpye commented Feb 4, 2022 • edited

0x4A6F commented Apr 11, 2023

0x4A6F commented Sep 20, 2020 •

edited

0x4A6F commented Oct 6, 2020 •

edited

benpye commented Feb 4, 2022 •

edited