Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liberation_ttf: Fix cross-compiling #96966

Merged
merged 1 commit into from Sep 3, 2020
Merged

liberation_ttf: Fix cross-compiling #96966

merged 1 commit into from Sep 3, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Sep 2, 2020

Motivation for this change

liberation_ttf runs python3 during build, hence it needs to be in nativeBuildInputs when cross-building.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka kampka added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Sep 2, 2020
@kampka
liberation_ttf: Fix cross-compiling
d4c42bf 
liberation_ttf runs python3 during build,
hence it needs to be in nativeBuildInputs
when cross-building.
@kampka
Copy link
Contributor Author

kampka commented Sep 2, 2020

@GrahamcOfBorg build liberation_ttf
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.liberation_ttf

@ofborg ofborg bot requested a review from 7c6f434c September 2, 2020 17:40
@7c6f434c 7c6f434c merged commit ccde657 into NixOS:staging Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampka @7c6f434c