Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f3d: init at 1.0.1 #96934

Merged
merged 1 commit into from Oct 10, 2020
Merged

f3d: init at 1.0.1 #96934

merged 1 commit into from Oct 10, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Sep 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

OPNA2608
OPNA2608 requested changes Sep 2, 2020
View reviewed changes
pkgs/applications/graphics/f3d/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/f3d/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/f3d/default.nix Outdated Show resolved Hide resolved
@OPNA2608
Copy link
Contributor

OPNA2608 commented Sep 3, 2020

LGTM if it runs for you.

Tested on non-NixOS Linux (Ubuntu 18.04). SIGABRTs on startup due to libGL, LD_LIBRARY_PATHing the system's libGL libraries works (afaik this is a known problem, see #9415). Not tested with any 3D model.
image

@bcdarwin
Copy link
Member Author

bcdarwin commented Sep 3, 2020

I have opened some 3d models and it works fine (except that it's compiled without the -r flag for ray tracing due to VTK not being compiled with necessary support). Same issue on non-NixOS Linux, but works on OS X.

@marsam marsam merged commit 69b0cf2 into NixOS:master Oct 10, 2020
@bcdarwin bcdarwin deleted the f3d branch October 13, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @OPNA2608 @marsam