Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ioquake3: 2019-05-29 -> 2020-08-29 #96935

Merged
merged 1 commit into from Jan 10, 2021
Merged

ioquake3: 2019-05-29 -> 2020-08-29 #96935

merged 1 commit into from Jan 10, 2021

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs rvolosatovs changed the title ioquake3: 2019-05-29 -> 2020-02-11 ioquake3: 2019-05-29 -> 2020-08-29 Sep 1, 2020
@ofborg ofborg bot requested review from abbradar and edolstra September 1, 2020 23:55
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 96935 run on x86_64-linux 1

2 packages built:
  • ioquake3
  • quake3demo

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build ioquake3

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

Please change pkgconfig in line 1 to pkg-config.

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build ioquake3

@SuperSandro2000 SuperSandro2000 merged commit 2cfa110 into NixOS:master Jan 10, 2021
@rvolosatovs rvolosatovs deleted the update/ioquake3 branch January 11, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvolosatovs @SuperSandro2000