Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdfcpu: 0.3.4 -> 0.3.5 #96967

Merged
merged 1 commit into from Sep 7, 2020
Merged

pdfcpu: 0.3.4 -> 0.3.5 #96967

merged 1 commit into from Sep 7, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 2, 2020 •
edited

Remove subPackages attribute as it causes the build to fail now.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit September 2, 2020 17:54
@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020 

warning: unknown setting 'experimental-features'
error: --- Error --- nix-daemon
builder for '/nix/store/07lwkniizmn41bc6l45lp00d1lvh7cxb-pdfcpu-0.3.5.drv' failed with exit code 1; last 10 log lines:
  Building subPackage ./pkg/filter
  Building subPackage ./pkg/font
  Building subPackage ./pkg/log
  Building subPackage ./pkg/pdfcpu
  Building subPackage ./pkg/pdfcpu/validate
  Building subPackage ./pkg/types
  running tests
  Failed access to font dir: mkdir /homeless-shelter: permission denied
  FAIL      github.com/pdfcpu/pdfcpu/pkg/api        0.001s
  FAIL

@doronbehar
Copy link
Contributor Author

Weird, from some reason I saw it was needed to remove the subPackages attr. Now the build passes for me, let's see what ofborg will say.

@cole-h
Copy link
Member

cole-h commented Sep 6, 2020

@ofborg eval

Happened due to 0 available inodes on the evaluator; has since been cleaned up.

@marsam marsam merged commit 90ee9e6 into NixOS:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @tomberek @cole-h @marsam